Skip to content

Commit 5cf08b3

Browse files
committed
fix: missing pbt->simple-pbt name changes, add simple-pbt to update-images.sh update yaml function (causing failing gha).
1 parent 6962ad7 commit 5cf08b3

File tree

6 files changed

+8
-4
lines changed

6 files changed

+8
-4
lines changed

.github/workflows/simple-pbt-e2e-test.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ name: E2E Test with simple-pbt
22
on:
33
- pull_request
44

5+
env:
6+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7+
58
jobs:
69
e2e:
710
runs-on: ubuntu-20.04

examples/v1beta1/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Experiments for the following algorithms:
4444

4545
- [HyperBand](./hp-tuning/hyperband.yaml)
4646

47-
- [PBT](./hp-tuning/pbt.yaml)
47+
- [PBT](./hp-tuning/simple-pbt.yaml)
4848

4949
### Neural Architecture Search
5050

examples/v1beta1/hp-tuning/simple-pbt.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ spec:
4343
containers:
4444
- name: training-container
4545
image: docker.io/kubeflowkatib/simple-pbt:latest
46-
imagePullPolicy: Always
4746
command:
4847
- "python3"
4948
- "/opt/pbt/pbt_test.py"

scripts/v1beta1/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ else
136136
docker build --platform linux/amd64 -t "${REGISTRY}/darts-cnn-cifar10-gpu:${TAG}" -f examples/${VERSION}/trial-images/darts-cnn-cifar10/Dockerfile.gpu .
137137

138138
echo -e "\nBuilding dynamic learning rate training container example for PBT...\n"
139-
docker build --platform linux/amd64 -t "${REGISTRY}/simple-pbt:${TAG}" -f examples/${VERSION}/trial-images/pbt/Dockerfile .
139+
docker build --platform linux/amd64 -t "${REGISTRY}/simple-pbt:${TAG}" -f examples/${VERSION}/trial-images/simple-pbt/Dockerfile .
140140
fi
141141

142142
echo -e "\nBuilding Tensorflow with summaries mnist training container example...\n"

scripts/v1beta1/update-images.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ ENAS_GPU="enas-cnn-cifar10-gpu"
8989
ENAS_CPU="enas-cnn-cifar10-cpu"
9090
DARTS_GPU="darts-cnn-cifar10-gpu"
9191
DARTS_CPU="darts-cnn-cifar10-cpu"
92+
SIMPLE_PBT="simple-pbt"
9293

9394
echo -e "Update Katib Trial training container images\n"
9495
update_yaml_files "./" "${OLD_PREFIX}${MXNET_MNIST}:.*" "${NEW_PREFIX}${MXNET_MNIST}:${TAG}"
@@ -98,5 +99,6 @@ update_yaml_files "./" "${OLD_PREFIX}${ENAS_GPU}:.*" "${NEW_PREFIX}${ENAS_GPU}:$
9899
update_yaml_files "./" "${OLD_PREFIX}${ENAS_CPU}:.*" "${NEW_PREFIX}${ENAS_CPU}:${TAG}"
99100
update_yaml_files "./" "${OLD_PREFIX}${DARTS_GPU}:.*" "${NEW_PREFIX}${DARTS_GPU}:${TAG}"
100101
update_yaml_files "./" "${OLD_PREFIX}${DARTS_CPU}:.*" "${NEW_PREFIX}${DARTS_CPU}:${TAG}"
102+
update_yaml_files "./" "${OLD_PREFIX}${SIMPLE_PBT}:.*" "${NEW_PREFIX}${SIMPLE_PBT}:${TAG}"
101103

102104
echo "Katib images have been updated"

test/e2e/v1beta1/hack/aws/argo_workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"multivariate-tpe": "examples/v1beta1/hp-tuning/multivariate-tpe.yaml",
7878
"cmaes": "examples/v1beta1/hp-tuning/cma-es.yaml",
7979
"hyperband": "examples/v1beta1/hp-tuning/hyperband.yaml",
80-
"pbt": "examples/v1beta1/hp-tuning/pbt.yaml",
80+
"pbt": "examples/v1beta1/hp-tuning/simple-pbt.yaml",
8181
"enas": "examples/v1beta1/nas/enas-cpu.yaml",
8282
"darts": "examples/v1beta1/nas/darts-cpu.yaml",
8383
"pytorchjob": "examples/v1beta1/kubeflow-training-operator/pytorchjob-mnist.yaml",

0 commit comments

Comments
 (0)