Skip to content

Commit 0cd662e

Browse files
committed
feedback: GHA updates
1 parent 87a0402 commit 0cd662e

File tree

4 files changed

+45
-7
lines changed

4 files changed

+45
-7
lines changed
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: E2E Test with simple-pbt
2+
on:
3+
- pull_request
4+
5+
jobs:
6+
e2e:
7+
runs-on: ubuntu-20.04
8+
timeout-minutes: 120
9+
steps:
10+
- name: Checkout
11+
uses: actions/checkout@v2
12+
13+
- name: Setup Test Env
14+
uses: ./.github/workflows/template-setup-e2e-test
15+
with:
16+
kubernetes-version: ${{ matrix.kubernetes-version }}
17+
18+
- name: Run e2e test with ${{ matrix.experiments }} experiments
19+
uses: ./.github/workflows/template-e2e-test
20+
with:
21+
experiments: ${{ matrix.experiments }}
22+
# Comma Delimited
23+
trial-images: simple-pbt
24+
25+
strategy:
26+
fail-fast: false
27+
matrix:
28+
# Detail: https://hub.docker.com/r/kindest/node
29+
# TODO (tenzen-y): We need to consider running tests on more kubernetes versions.
30+
# kubernetes-version: ["v1.20.15", "v1.21.12", "v1.22.9", "v1.23.6", "v1.24.1"]
31+
kubernetes-version: ["v1.21.12", "v1.22.9", "v1.23.6"]
32+
# Comma Delimited
33+
experiments: ["simple-pbt"]

cmd/suggestion/pbt/v1beta1/Dockerfile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
1-
FROM python:3.9
1+
FROM python:3.9-slim
22

33
ENV TARGET_DIR /opt/katib
44
ENV SUGGESTION_DIR cmd/suggestion/pbt/v1beta1
55
ENV GRPC_HEALTH_PROBE_VERSION v0.4.6
66

77
RUN if [ "$(uname -m)" = "ppc64le" ] || [ "$(uname -m)" = "aarch64" ]; then \
88
apt-get -y update && \
9-
apt-get -y install gfortran libopenblas-dev liblapack-dev && \
9+
apt-get -y install gfortran libopenblas-dev liblapack-dev wget && \
10+
apt-get clean && \
11+
rm -rf /var/lib/apt/lists/*; \
12+
else \
13+
apt-get -y update && \
14+
apt-get -y install wget && \
1015
apt-get clean && \
1116
rm -rf /var/lib/apt/lists/*; \
1217
fi

examples/v1beta1/hp-tuning/pbt.yaml renamed to examples/v1beta1/hp-tuning/simple-pbt.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
apiVersion: kubeflow.org/v1beta1
22
kind: Experiment
33
metadata:
4-
name: random-experiment
5-
namespace: 'kubeflow'
4+
namespace: kubeflow
5+
name: simple-pbt
66
spec:
7-
maxTrialCount: 12
8-
parallelTrialCount: 12
7+
maxTrialCount: 2
8+
parallelTrialCount: 2
99
maxFailedTrialCount: 3
1010
resumePolicy: FromVolume
1111
objective:

examples/v1beta1/trial-images/simple-pbt/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.9
1+
FROM python:3.9-slim
22

33
ADD examples/v1beta1/trial-images/simple-pbt /opt/pbt
44
WORKDIR /opt/pbt

0 commit comments

Comments
 (0)