Fix Istio sidecar injection by moving from annotations to labels

Signed-off-by: madmecodes <[email protected]>

Author: madmecodes

manifests/v1beta1/components/controller/controller.yaml

@@ -15,10 +15,10 @@ spec:
     metadata:
       labels:
         katib.kubeflow.org/component: controller
+        sidecar.istio.io/inject: "false"
       annotations:
         prometheus.io/scrape: "true"
         prometheus.io/port: "8080"
-        sidecar.istio.io/inject: "false"
     spec:
       serviceAccountName: katib-controller
       containers:

manifests/v1beta1/components/db-manager/db-manager.yaml

@@ -15,7 +15,6 @@ spec:
     metadata:
       labels:
         katib.kubeflow.org/component: db-manager
-      annotations:
         sidecar.istio.io/inject: "false"
     spec:
       containers:

manifests/v1beta1/components/mysql/mysql.yaml

@@ -17,7 +17,6 @@ spec:
     metadata:
       labels:
         katib.kubeflow.org/component: mysql
-      annotations:
         sidecar.istio.io/inject: "false"
     spec:
       containers:

manifests/v1beta1/components/postgres/postgres.yaml

@@ -17,8 +17,8 @@ spec:
     metadata:
       labels:
         katib.kubeflow.org/component: postgres
-      annotations:
         sidecar.istio.io/inject: "false"
+      annotations:
     spec:
       containers:
         - name: katib-postgres

manifests/v1beta1/components/ui/ui.yaml

@@ -15,7 +15,6 @@ spec:
     metadata:
       labels:
         katib.kubeflow.org/component: ui
-      annotations:
         sidecar.istio.io/inject: "false"
     spec:
       containers:

manifests/v1beta1/installs/katib-with-kubeflow/patches/istio-sidecar-injection.yaml

@@ -6,5 +6,5 @@ metadata:
 spec:
   template:
     metadata:
-      annotations:
+      labels:
         sidecar.istio.io/inject: "true"