Skip to content

Commit 25738c1

Browse files
author
florianfreiburg
committed
Remove Columbus Day as public holiday from US
1 parent 2e66003 commit 25738c1

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

src/Holiday/Us/Us.php

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ protected function getPublicHolidays($year)
5050
$holidays = [
5151
new Holiday(clone $christmas, 'Christmas', $this->timezone),
5252
new Holiday(clone $thanksgiving, 'Thanksgiving Day', $this->timezone),
53-
new Holiday(new \DateTimeImmutable('second Monday of October '.$year, $this->timezone), 'Columbus Day', $this->timezone),
5453
new Holiday(new \DateTimeImmutable('first Monday of September '.$year, $this->timezone), 'Labor Day', $this->timezone),
5554
new Holiday(new \DateTimeImmutable('last Monday of May '.$year, $this->timezone), 'Memorial Day', $this->timezone),
5655
new Holiday(new \DateTimeImmutable('third Monday of February '.$year, $this->timezone), "President's Day", $this->timezone),

tests/Holiday/Us/UsMiTest.php

-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public function testIsHoliday()
4343
$juneteenthDay = new \DateTime('2021-06-19', $this->timezone);
4444
$laborDay = new \DateTime('2014-09-01', $this->timezone);
4545
$veteransDay = new \DateTime('2014-11-11', $this->timezone);
46-
$columbusDay = new \DateTime('2014-10-13', $this->timezone);
4746

4847
$dummyDate = new \DateTime('2015-03-11', $this->timezone);
4948

@@ -59,7 +58,6 @@ public function testIsHoliday()
5958
$this->assertEquals(true, count($this->holiday->isHoliday($juneteenthDay)) > 0, 'Juneteenth Day');
6059
$this->assertEquals(true, count($this->holiday->isHoliday($laborDay)) > 0, 'Labor Day');
6160
$this->assertEquals(true, count($this->holiday->isHoliday($veteransDay)) > 0, 'Veterans Day');
62-
$this->assertEquals(true, count($this->holiday->isHoliday($columbusDay)) > 0, 'Columbus Day');
6361
$this->assertNotEquals(true, count($this->holiday->isHoliday($dummyDate)) > 0, 'Dummy Date Test');
6462
}
6563

tests/Holiday/Us/UsTest.php

-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public function testIsHoliday()
4242
$memorialDay = new \DateTime('2015-05-25', $this->timezone);
4343
$juneteenthDay = new \DateTime('2021-06-19', $this->timezone);
4444
$veteransDay = new \DateTime('2014-11-11', $this->timezone);
45-
$columbusDay = new \DateTime('2014-10-13', $this->timezone);
4645

4746
$dummyDate = new \DateTime('2015-03-11', $this->timezone);
4847

@@ -57,7 +56,6 @@ public function testIsHoliday()
5756
$this->assertEquals(true, count($this->holiday->isHoliday($memorialDay)) > 0, 'Memorial Day');
5857
$this->assertEquals(true, count($this->holiday->isHoliday($juneteenthDay)) > 0, 'Juneteenth Day');
5958
$this->assertEquals(true, count($this->holiday->isHoliday($veteransDay)) > 0, 'Veterans Day');
60-
$this->assertEquals(true, count($this->holiday->isHoliday($columbusDay)) > 0, 'Columbus Day');
6159
$this->assertNotEquals(true, count($this->holiday->isHoliday($dummyDate)) > 0, 'Dummy Date Test');
6260
}
6361

0 commit comments

Comments
 (0)