Skip to content

Commit 2bab5ec

Browse files
kriegaexkriegaex
committed
[mojohaus#389] Add option 'blockSystemExit' to 'java' mojo
This new option enables users to stop programs called by 'exec:java' from calling System::exit, terminating not just the mojo but the whole Maven JVM. Closes mojohaus#389. Relates to mojohaus#388.
1 parent 75b2e74 commit 2bab5ec

File tree

16 files changed

+466
-0
lines changed

16 files changed

+466
-0
lines changed

‎pom.xml

+14
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,15 @@
335335
<invoker.parallelThreads>1</invoker.parallelThreads>
336336
</properties>
337337
</profile>
338+
<profile>
339+
<id>java17+</id>
340+
<activation>
341+
<jdk>[17,)</jdk>
342+
</activation>
343+
<properties>
344+
<invoker.security.manager>-Djava.security.manager=allow</invoker.security.manager>
345+
</properties>
346+
</profile>
338347
<profile>
339348
<id>run-its</id>
340349
<build>
@@ -360,6 +369,11 @@
360369
<scriptVariables>
361370
<projectVersion>${project.version}</projectVersion>
362371
</scriptVariables>
372+
<!--
373+
Necessary on JDK 17+ for ITs "mexec-gh-389-block-exit-*" to avoid "UnsupportedOperationException:
374+
The Security Manager is deprecated and will be removed in a future release". See profile 'java17+'.
375+
-->
376+
<mavenOpts>${invoker.security.manager}</mavenOpts>
363377
</configuration>
364378
<executions>
365379
<execution>

‎src/it/projects/mexec-gh-389-block-exit-non-zero/invoker.properties

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
invoker.goals = clean process-classes
2+
invoker.buildResult = failure
3+
invoker.debug = false

‎src/it/projects/mexec-gh-389-block-exit-non-zero/pom.xml

+47
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<parent>
7+
<groupId>org.codehaus.mojo.exec.it</groupId>
8+
<artifactId>parent</artifactId>
9+
<version>0.1</version>
10+
</parent>
11+
12+
<artifactId>mexec-gh-389</artifactId>
13+
<version>0.0.1-SNAPSHOT</version>
14+
15+
<build>
16+
<plugins>
17+
<plugin>
18+
<groupId>org.codehaus.mojo</groupId>
19+
<artifactId>exec-maven-plugin</artifactId>
20+
<version>@project.version@</version>
21+
<executions>
22+
<execution>
23+
<phase>process-classes</phase>
24+
<goals>
25+
<goal>java</goal>
26+
</goals>
27+
<configuration>
28+
<mainClass>Main</mainClass>
29+
<blockSystemExit>true</blockSystemExit>
30+
<systemProperties>
31+
<systemProperty>
32+
<key>exitBehaviour</key>
33+
<value>system-exit-error</value>
34+
</systemProperty>
35+
</systemProperties>
36+
<arguments>
37+
<argument>one</argument>
38+
<argument>two</argument>
39+
<argument>three</argument>
40+
</arguments>
41+
</configuration>
42+
</execution>
43+
</executions>
44+
</plugin>
45+
</plugins>
46+
</build>
47+
</project>

‎src/it/projects/mexec-gh-389-block-exit-non-zero/src/main/java/Main.java

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import java.util.Arrays;
2+
3+
public class Main
4+
{
5+
public static void main( String[] args )
6+
{
7+
System.out.println( Arrays.toString( args ) );
8+
switch ( System.getProperty( "exitBehaviour", "ok" ) )
9+
{
10+
case "throw-exception":
11+
throw new RuntimeException( "uh-oh" );
12+
case "system-exit-ok":
13+
System.exit( 0 );
14+
case "system-exit-error":
15+
System.exit( 123 );
16+
}
17+
System.out.println( "OK" );
18+
}
19+
}

‎src/it/projects/mexec-gh-389-block-exit-non-zero/verify.groovy

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
def buildLogLines = new File( basedir, "build.log" ).readLines()
21+
22+
// Find "System::exit was called" line index
23+
def infoMessageLineNumber = buildLogLines.indexOf("[INFO] System::exit was called with return code 123")
24+
assert infoMessageLineNumber > 0
25+
// Verify that preceding line is program output
26+
assert buildLogLines[infoMessageLineNumber - 1] == "[one, two, three]"
27+
// Verify that subsequent lines contain the beginning of the thrown SystemExitException stack trace
28+
assert buildLogLines[infoMessageLineNumber + 1].startsWith("[WARNING]")
29+
assert buildLogLines[infoMessageLineNumber + 2].contains("SystemExitException: System::exit was called with return code 123")
30+
assert buildLogLines[infoMessageLineNumber + 3].contains("SystemExitManager.checkExit (SystemExitManager.java")

‎src/it/projects/mexec-gh-389-block-exit-zero/invoker.properties

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
invoker.goals = clean process-classes
2+
invoker.buildResult = success
3+
invoker.debug = false

‎src/it/projects/mexec-gh-389-block-exit-zero/pom.xml

+47
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<parent>
7+
<groupId>org.codehaus.mojo.exec.it</groupId>
8+
<artifactId>parent</artifactId>
9+
<version>0.1</version>
10+
</parent>
11+
12+
<artifactId>mexec-gh-389</artifactId>
13+
<version>0.0.1-SNAPSHOT</version>
14+
15+
<build>
16+
<plugins>
17+
<plugin>
18+
<groupId>org.codehaus.mojo</groupId>
19+
<artifactId>exec-maven-plugin</artifactId>
20+
<version>@project.version@</version>
21+
<executions>
22+
<execution>
23+
<phase>process-classes</phase>
24+
<goals>
25+
<goal>java</goal>
26+
</goals>
27+
<configuration>
28+
<mainClass>Main</mainClass>
29+
<blockSystemExit>true</blockSystemExit>
30+
<systemProperties>
31+
<systemProperty>
32+
<key>exitBehaviour</key>
33+
<value>system-exit-ok</value>
34+
</systemProperty>
35+
</systemProperties>
36+
<arguments>
37+
<argument>one</argument>
38+
<argument>two</argument>
39+
<argument>three</argument>
40+
</arguments>
41+
</configuration>
42+
</execution>
43+
</executions>
44+
</plugin>
45+
</plugins>
46+
</build>
47+
</project>

‎src/it/projects/mexec-gh-389-block-exit-zero/src/main/java/Main.java

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import java.util.Arrays;
2+
3+
public class Main
4+
{
5+
public static void main( String[] args )
6+
{
7+
System.out.println( Arrays.toString( args ) );
8+
switch ( System.getProperty( "exitBehaviour", "ok" ) )
9+
{
10+
case "throw-exception":
11+
throw new RuntimeException( "uh-oh" );
12+
case "system-exit-ok":
13+
System.exit( 0 );
14+
case "system-exit-error":
15+
System.exit( 123 );
16+
}
17+
System.out.println( "OK" );
18+
}
19+
}

‎src/it/projects/mexec-gh-389-block-exit-zero/verify.groovy

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
def buildLogLines = new File( basedir, "build.log" ).readLines()
21+
22+
// Find "System::exit was called" line index
23+
def infoMessageLineNumber = buildLogLines.indexOf("[INFO] System::exit was called with return code 0")
24+
assert infoMessageLineNumber > 0
25+
// Verify that preceding line is program output
26+
assert buildLogLines[infoMessageLineNumber - 1] == "[one, two, three]"

‎src/it/projects/mexec-gh-389-default-permit-exit/invoker.properties

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
invoker.goals = clean process-classes
2+
# Cannot not check result, because build terminates unexpectedly
3+
# invoker.buildResult = failure
4+
invoker.debug = false

‎src/it/projects/mexec-gh-389-default-permit-exit/pom.xml

+49
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<parent>
7+
<groupId>org.codehaus.mojo.exec.it</groupId>
8+
<artifactId>parent</artifactId>
9+
<version>0.1</version>
10+
</parent>
11+
12+
<artifactId>mexec-gh-389</artifactId>
13+
<version>0.0.1-SNAPSHOT</version>
14+
15+
<build>
16+
<plugins>
17+
<plugin>
18+
<groupId>org.codehaus.mojo</groupId>
19+
<artifactId>exec-maven-plugin</artifactId>
20+
<version>@project.version@</version>
21+
<executions>
22+
<execution>
23+
<phase>process-classes</phase>
24+
<goals>
25+
<goal>java</goal>
26+
</goals>
27+
<configuration>
28+
<mainClass>Main</mainClass>
29+
<!-- This is the default, no need to specify it -->
30+
<!--<blockSystemExit>false</blockSystemExit>-->
31+
<systemProperties>
32+
<systemProperty>
33+
<key>exitBehaviour</key>
34+
<!-- System.exit with any return code will terminate the JVM and the whole Maven process -->
35+
<value>system-exit-ok</value>
36+
</systemProperty>
37+
</systemProperties>
38+
<arguments>
39+
<argument>one</argument>
40+
<argument>two</argument>
41+
<argument>three</argument>
42+
</arguments>
43+
</configuration>
44+
</execution>
45+
</executions>
46+
</plugin>
47+
</plugins>
48+
</build>
49+
</project>

‎src/it/projects/mexec-gh-389-default-permit-exit/src/main/java/Main.java

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import java.util.Arrays;
2+
3+
public class Main
4+
{
5+
public static void main( String[] args )
6+
{
7+
System.out.println( Arrays.toString( args ) );
8+
switch ( System.getProperty( "exitBehaviour", "ok" ) )
9+
{
10+
case "throw-exception":
11+
throw new RuntimeException( "uh-oh" );
12+
case "system-exit-ok":
13+
System.exit( 0 );
14+
case "system-exit-error":
15+
System.exit( 123 );
16+
}
17+
System.out.println( "OK" );
18+
}
19+
}

‎src/it/projects/mexec-gh-389-default-permit-exit/verify.groovy

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
def buildLogLines = new File( basedir, "build.log" ).readLines()
21+
22+
// Second-last line is the last line the called program prints before exiting the JVM with System.exit.
23+
// Last line is "Running post-build script: ...", i.e. we need to disregard it.
24+
assert buildLogLines[-2] == "[one, two, three]"

0 commit comments

Comments
 (0)