Testing fixes

Author: Daniel Brain

gulpfile.js

@@ -12,47 +12,47 @@ var MODULE_NAME = 'postRobot';
 
 var WEBPACK_CONFIG = {
     module: {
-      loaders: [
-        {
-            test: /\.js$/,
-            exclude: /(node_modules|bower_components)/,
-            loader: 'babel',
-            query: {
-            presets: ['es2015'],
-            plugins: [
-              'transform-object-rest-spread',
-              'syntax-object-rest-spread',
-              'transform-es3-property-literals',
-              'transform-es3-member-expression-literals',
-            ['transform-es2015-for-of', {loose: true}]
-          ]
-        }
-        }
-    ]
-  },
+        loaders: [
+            {
+                test: /\.js$/,
+                exclude: /(node_modules|bower_components)/,
+                loader: 'babel',
+                query: {
+                    presets: ['es2015'],
+                    plugins: [
+                        'transform-object-rest-spread',
+                        'syntax-object-rest-spread',
+                        'transform-es3-property-literals',
+                        'transform-es3-member-expression-literals',
+                        ['transform-es2015-for-of', {loose: true}]
+                    ]
+                }
+            }
+        ]
+    },
     output: {
-      filename: `${FILE_NAME}.js`,
-      libraryTarget: 'umd',
-      umdNamedDefine: true,
-      library: MODULE_NAME
-  },
+        filename: `${FILE_NAME}.js`,
+        libraryTarget: 'umd',
+        umdNamedDefine: true,
+        library: MODULE_NAME
+    },
     bail: true
 };
 
 var WEBPACK_CONFIG_MIN = Object.assign({}, WEBPACK_CONFIG, {
     output: {
-      filename: `${FILE_NAME}.min.js`,
-      libraryTarget: 'umd',
-      umdNamedDefine: true,
-      library: MODULE_NAME
-  },
+        filename: `${FILE_NAME}.min.js`,
+        libraryTarget: 'umd',
+        umdNamedDefine: true,
+        library: MODULE_NAME
+    },
     plugins: [
-      new webpack.optimize.UglifyJsPlugin({
-        test: /\.js$/,
-        exclude: /(node_modules|bower_components)/,
-        minimize: true
-    })
-  ]
+        new webpack.optimize.UglifyJsPlugin({
+            test: /\.js$/,
+            exclude: /(node_modules|bower_components)/,
+            minimize: true
+        })
+    ]
 });
 
 gulp.task('webpack', ['lint'], function() {
@@ -76,24 +76,24 @@ gulp.task('lint', function() {
 gulp.task('karma', function (done) {
 
     var server = new Server({
-      configFile: __dirname + '/karma.conf.js',
-      singleRun: true,
-      client: {
-        captureConsole: false
-    }
-  });
+        configFile: __dirname + '/karma.conf.js',
+        singleRun: true,
+        client: {
+            captureConsole: true
+        }
+    });
 
     server.on('browser_error', function (browser, err) {
-      console.log('Karma Run Failed: ' + err.message);
-      throw err;
-  });
+        console.log('Karma Run Failed: ' + err.message);
+        throw err;
+    });
 
     server.on('run_complete', function (browsers, results) {
-      if (results.failed) {
-          return done(new Error('Karma: Tests Failed'));
-      }
-      done();
-  });
+        if (results.failed) {
+            return done(new Error('Karma: Tests Failed'));
+        }
+        done();
+    });
 
     server.start();
 });

karma.conf.js

@@ -28,7 +28,8 @@ module.exports = function(config) {
             require('karma-phantomjs-launcher'),
             require('karma-chrome-launcher'),
             require('karma-sinon-chai'),
-            require('karma-coverage')
+            require('karma-coverage'),
+            require('karma-spec-reporter')
         ],
 
 
@@ -47,7 +48,7 @@ module.exports = function(config) {
         // possible values: 'dots', 'progress'
         // available reporters: https://npmjs.org/browse/keyword/karma-reporter
         reporters: [
-            'progress',
+            'spec',
             'coverage'
         ],
 

package.json

@@ -50,6 +50,7 @@
     "karma-mocha": "^1.0.1",
     "karma-phantomjs-launcher": "^1.0.0",
     "karma-sinon-chai": "^1.2.0",
+    "karma-spec-reporter": "0.0.26",
     "lolex": "^1.5.0",
     "mocha": "^2.4.5",
     "phantomjs-prebuilt": "^2.1.7",

src/drivers/listeners.js

@@ -50,7 +50,7 @@ export function addRequestListener(name, win, options, override) {
 
     if (listener) {
         if (override) {
-            removeRequestListener(listener.options);
+            removeRequestListener(listener);
         } else {
             throw new Error(`Request listener already exists for ${name}`);
         }

test/test.js

@@ -1,4 +1,10 @@
 
+window.console.karma = function() {
+    var karma = window.karma || (window.top && window.top.karma) || (window.opener && window.opener.karma);
+    karma.log('debug', arguments);
+    console.log.apply(console, arguments);
+};
+
 function createIframe(name) {
     var frame = document.createElement('iframe');
     frame.src = '/base/test/' + name;
@@ -12,12 +18,12 @@ describe('post-robot', function() {
 
     it('should set up a simple server and listen for a request', function(done) {
 
-        postRobot.on('foo', function() {
+        postRobot.on('foobu', function() {
             done();
         });
 
         postRobot.send(child, 'sendMessageToParent', {
-            messageName: 'foo'
+            messageName: 'foobu'
         });
     });
 
@@ -44,13 +50,13 @@ describe('post-robot', function() {
 
             messageName: 'foo',
             data: {
-                foo: 'bar'
+                foo: 'bar2'
             }
 
         }).then(function() {
 
             return postRobot.send(child, 'foo', function(err, data) {
-                assert.equal(data.foo, 'bar');
+                assert.equal(data.foo, 'bar2');
                 done();
             });
 
@@ -77,4 +83,23 @@ describe('post-robot', function() {
         });
     });
 
+    it('should pass a function across windows and be able to call it later', function(done) {
+
+        postRobot.send(child, 'setupListener', {
+
+            messageName: 'foo',
+            data: {
+                done: done
+            }
+
+        }).then(function() {
+
+            return postRobot.send(child, 'foo').then(function(data) {
+
+                console.karma(data);
+                data.done();
+            });
+        });
+    });
+
 });