Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Commit 903252e

Browse files
author
Daniel Brain
committed
Do not set up response listener for fire-and-forget message
1 parent c54c306 commit 903252e

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

src/public/client.js

+21-17
Original file line numberDiff line numberDiff line change
@@ -110,25 +110,29 @@ export function request(options : RequestOptionsType) : ZalgoPromise<ResponseMes
110110

111111
return new ZalgoPromise((resolve, reject) => {
112112

113-
let responseListener : ResponseListenerType = {
114-
name,
115-
window: win,
116-
domain,
117-
respond(err, result) {
118-
if (!err) {
119-
hasResult = true;
120-
requestPromises.splice(requestPromises.indexOf(requestPromise, 1));
121-
}
122-
123-
if (err) {
124-
reject(err);
125-
} else {
126-
resolve(result);
113+
let responseListener : ResponseListenerType;
114+
115+
if (!options.fireAndForget) {
116+
responseListener = {
117+
name,
118+
window: win,
119+
domain,
120+
respond(err, result) {
121+
if (!err) {
122+
hasResult = true;
123+
requestPromises.splice(requestPromises.indexOf(requestPromise, 1));
124+
}
125+
126+
if (err) {
127+
reject(err);
128+
} else {
129+
resolve(result);
130+
}
127131
}
128-
}
129-
};
132+
};
130133

131-
addResponseListener(hash, responseListener);
134+
addResponseListener(hash, responseListener);
135+
}
132136

133137
sendMessage(win, {
134138
type: CONSTANTS.POST_MESSAGE_TYPE.REQUEST,

0 commit comments

Comments
 (0)