Remove callback support

Author: Daniel Brain

src/drivers/receive/types.js

@@ -58,7 +58,7 @@ export let RECEIVE_MESSAGE_TYPES = {
 
                 let data = message.data;
 
-                return promise.deNodeify(options.handler, { source, origin, data });
+                return options.handler({ source, origin, data });
 
             }).then(data => {
 

src/lib/promise.js

@@ -39,25 +39,6 @@ export let promise = {
         });
     },
 
-    deNodeify(method, ...args) {
-        return new Promise((resolve, reject) => {
-            try {
-                if (args.length < method.length) {
-                    return method(...args, (err, result) => {
-                        return err ? reject(err) : resolve(result);
-                    });
-                }
-
-                return promise.run(() => {
-                    return method(...args);
-                }).then(resolve, reject);
-
-            } catch (err) {
-                return reject(err);
-            }
-        });
-    },
-
     map(items, method) {
 
         let results = [];
@@ -68,4 +49,4 @@ export let promise = {
         }
         return Promise.all(results);
     }
-};
+};

src/public/client.js

@@ -149,40 +149,28 @@ export function request(options) {
         return requestPromise;
     });
 
-    return promise.nodeify(prom, options.callback);
+    return prom;
 }
 
-export function send(window, name, data, options, callback) {
-
-    if (!callback) {
-        if (!options && typeof data === 'function') {
-            callback = data;
-            options = {};
-            data = {};
-        } else if (typeof options === 'function') {
-            callback = options;
-            options = {};
-        }
-    }
+export function send(window, name, data, options) {
 
     options = options || {};
     options.window = window;
     options.name = name;
     options.data = data;
-    options.callback = callback;
 
     return request(options);
 }
 
-export function sendToParent(name, data, options, callback) {
+export function sendToParent(name, data, options) {
 
     let win = getAncestor();
 
     if (!win) {
         return new promise.Promise((resolve, reject) => reject(new Error('Window does not have a parent')));
     }
 
-    return send(win, name, data, options, callback);
+    return send(win, name, data, options);
 }
 
 export function client(options = {}) {
@@ -192,8 +180,8 @@ export function client(options = {}) {
     }
 
     return {
-        send(name, data, callback) {
-            return send(options.window, name, data, options, callback);
+        send(name, data) {
+            return send(options.window, name, data, options);
         }
     };
 }

test/test.js

@@ -102,25 +102,6 @@ describe('[post-robot] happy cases', function() {
         });
     });
 
-    it('should message a child and expect a response with a callback', function(done) {
-
-        postRobot.send(childFrame, 'setupListener', {
-
-            messageName: 'foo',
-            data: {
-                foo: 'bar2'
-            }
-
-        }).then(function() {
-
-            return postRobot.send(childFrame, 'foo', function(err, event) {
-                assert.equal(event.data.foo, 'bar2');
-                done();
-            });
-
-        }).catch(done);
-    });
-
     it('should pass a function across windows and be able to call it later', function(done) {
 
         postRobot.send(childFrame, 'setupListener', {
@@ -331,18 +312,7 @@ describe('[post-robot] error cases', function() {
             assert.ok(err);
         });
     });
-
-    it('should get a callback error when messaging with an unknown name', function(done) {
-
-        postRobot.send(childFrame, 'doesntexist', function(err, event) {
-            assert.ok(err);
-            if (event) {
-                throw new Error('Expected event to be blank');
-            }
-            done();
-        });
-    });
-
+    
     it('should error out if you try to register the same listener name twice', function() {
 
         postRobot.on('onceonly', function() {