Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Vscode walkthrough -> Webview drawer walkthrough #467

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Apr 3, 2025

Resolves #447

Add walkthrough drawer to guide initial configuration steps

  • Replace walkthrough.md files with drawer based walkthrough in webview. Add short/long description to ensure nothing is lost from moving from markdown files.
  • Update Patternfly version / icon version to fix version mismatch causing icon alignment issues.
  • Parse 'settingsYaml' path (Provider config yaml settings file) for api key status & default config usage status. Listen for changes in this provider config to update walkthrough drawer as we do for the settings.json config changes.

TODO in follow up PR:
#477

@ibolton336 ibolton336 requested a review from a team as a code owner April 3, 2025 02:19
@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from aabb9d3 to 173fd3e Compare April 3, 2025 02:20
@ibolton336 ibolton336 marked this pull request as draft April 3, 2025 13:08
@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from 6b5ebe9 to 7c9dc56 Compare April 4, 2025 16:18
@ibolton336 ibolton336 marked this pull request as ready for review April 4, 2025 16:20
@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from b000c81 to 2fdccbe Compare April 8, 2025 16:19
@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from e19bb6b to 4c998d4 Compare April 9, 2025 14:51
@ibolton336 ibolton336 requested a review from djzager April 9, 2025 14:57
@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from 31f9959 to 63b4216 Compare April 9, 2025 16:02
djzager
djzager previously approved these changes Apr 10, 2025
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking issue with the linter complaints.

@ibolton336 ibolton336 force-pushed the analysis-walkthrough-proto branch from 0ed2f37 to 67a1af3 Compare April 10, 2025 14:31
@ibolton336 ibolton336 requested a review from djzager April 10, 2025 14:32
@ibolton336 ibolton336 merged commit f704d60 into konveyor:main Apr 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Walkthrough to Webview-Based Welcome Screen
2 participants