Analysis incident Limit setting does not limit the number of incidents

[sshveta]

I changed the default incident limit from 10000 to 5 or 7 . That did not limit the number of incidents . Analysis showed standard 19 incidents each time .

[sshveta]

logs 
=============
ai rpc server has been spawned! [1099302]
Added request callback: echo
Added request callback: shutdown
Added request callback: exit
Added request callback: initialize
Added request callback: setConfig
Added request callback: analysis_engine.Analyze
Added request callback: testRCM
Added request callback: getCodeplanAgentSolution
waited 30000ms for the kai rpc server to be ready, continuing anyway
kai rpc server successfully started [pid: 1099302]
serverState change from [starting] to [readyToInitialize]
serverState change from [readyToInitialize] to [initializing]
Sending 'initialize' request: {"rootPath":"/home/sshveta/Work/applications/tackle-testapp-public","modelProvider":{"provider":"ChatOpenAI","args":{"model":"gpt-4o"}},"logConfig":{"logLevel":"ERROR","fileLogLevel":"ERROR","logDirPath":"/home/sshveta/Work/applications/tackle-testapp-public/.vscode/konveyor-logs"},"demoMode":false,"cacheDir":null,"traceEnabled":true,"analyzerLspRpcPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/kai/linux-x64/kai-analyzer-rpc","analyzerLspLspPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/jdtls/bin/jdtls","analyzerLspRulesPaths":["/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/rulesets"],"analyzerLspJavaBundlePaths":["/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/jdtls-bundles/java-analyzer-bundle/java-analyzer-bundle.core/target/java-analyzer-bundle.core-1.0.0-SNAPSHOT.jar"],"analyzerLspDepLabelsPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/opensource-labels-file/maven.default.index","analyzerLspExcludedPaths":["/home/sshveta/Work/applications/tackle-testapp-public/.git/","/home/sshveta/Work/applications/tackle-testapp-public/.vscode/","/home/sshveta/Work/applications/tackle-testapp-public/target/"]}
'initialize' response: {"processId":null,"rootPath":"/home/sshveta/Work/applications/tackle-testapp-public","modelProvider":{"provider":"ChatOpenAI","args":{"model":"gpt-4o"},"template":null,"llama_header":null,"llm_retries":5,"llm_retry_delay":10},"logConfig":{"logLevel":"ERROR","stderrLogLevel":"TRACE","fileLogLevel":"ERROR","logDirPath":"/home/sshveta/Work/applications/tackle-testapp-public/.vscode/konveyor-logs","logFileName":"kai_server.log"},"demoMode":false,"cacheDir":"/tmp/_MEIjMWn2H/data/llm_cache","traceEnabled":true,"failOnCacheMismatch":false,"enableReflection":true,"analyzerLspLspPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/jdtls/bin/jdtls","analyzerLspRpcPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/kai/linux-x64/kai-analyzer-rpc","analyzerLspRulesPaths":["/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/rulesets"],"analyzerLspJavaBundlePaths":["/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/jdtls-bundles/java-analyzer-bundle/java-analyzer-bundle.core/target/java-analyzer-bundle.core-1.0.0-SNAPSHOT.jar"],"analyzerLspLabelSelector":"","analyzerLspDepLabelsPath":"/home/sshveta/.vscode/extensions/konveyor.konveyor-ai-0.1.0-pre.2/assets/opensource-labels-file/maven.default.index","analyzerLspExcludedPaths":["/home/sshveta/Work/applications/tackle-testapp-public/.git","/home/sshveta/Work/applications/tackle-testapp-public/.vscode","/home/sshveta/Work/applications/tackle-testapp-public/target"]}
kai rpc server is initialized!
serverState change from [initializing] to [running]
Sending 'analysis_engine.Analyze' request with params: {"label_selector":"(konveyor.io/target=cloud-readiness || konveyor.io/target=quarkus) || (discovery)","reset_cache":true}
Response received. Summary: {"wellFormed":true,"rawIncidentCount":19,"incidentCount":19,"partialAnalysis":{}}

[sjd78]

Requires konveyor/kai#550

editor-extensions/vscode/src/client/analyzerClient.ts

Lines 339 to 344 in e941fe3

	// TODO: Once konveyor/kai#550 is resolved, analyzer configurations can be supported
	// analyzerIncidentLimit: getConfigIncidentLimit(),
	// analyzerContextLines: getConfigContextLines(),
	// analyzerCodeSnipLimit: getConfigCodeSnipLimit(),
	// analyzerAnalyzeKnownLibraries: getConfigAnalyzeKnownLibraries(),
	// analyzerAnalyzeDependencies: getConfigAnalyzeDependencies(),