chore: removes code duplication at handling HEAD method (#1400)

Author: tinovyatkin

lib/application.js

@@ -10,7 +10,6 @@ const debug = require('debug')('koa:application');
 const onFinished = require('on-finished');
 const response = require('./response');
 const compose = require('koa-compose');
-const isJSON = require('koa-is-json');
 const context = require('./context');
 const request = require('./request');
 const statuses = require('statuses');
@@ -225,9 +224,10 @@ function respond(ctx) {
     return res.end();
   }
 
-  if ('HEAD' == ctx.method) {
-    if (!res.headersSent && isJSON(body)) {
-      ctx.length = Buffer.byteLength(JSON.stringify(body));
+  if ('HEAD' === ctx.method) {
+    if (!res.headersSent && !ctx.response.has('Content-Length')) {
+      const { length } = ctx.response;
+      if (Number.isInteger(length)) ctx.length = length;
     }
     return res.end();
   }

package.json

@@ -40,7 +40,6 @@
     "is-generator-function": "^1.0.7",
     "koa-compose": "^4.1.0",
     "koa-convert": "^1.2.0",
-    "koa-is-json": "^1.0.0",
     "on-finished": "^2.3.0",
     "only": "~0.0.2",
     "parseurl": "^1.3.2",

test/application/respond.js

@@ -173,6 +173,26 @@ describe('app.respond', () => {
       assert(!res.text);
     });
 
+    it('should keep stream header if set manually', async() => {
+      const app = new Koa();
+
+      const { length } = fs.readFileSync('package.json');
+
+      app.use(ctx => {
+        ctx.length = length;
+        ctx.body = fs.createReadStream('package.json');
+      });
+
+      const server = app.listen();
+
+      const res = await request(server)
+        .head('/')
+        .expect(200);
+
+      assert.equal(res.header['content-length'], length);
+      assert(!res.text);
+    });
+
     it('should respond with a 404 if no body was set', () => {
       const app = new Koa();