Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable preparer interface to pre operations #964

Closed
wants to merge 1 commit into from
Closed

enable preparer interface to pre operations #964

wants to merge 1 commit into from

Conversation

developer-guy
Copy link
Collaborator

fixes #539 also duplicates #951

PTAL @imjasonh

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 52.02%. Comparing base (2b470fc) to head (e4881ae).
Report is 621 commits behind head on main.

Files with missing lines Patch % Lines
pkg/publish/default.go 0.00% 14 Missing ⚠️
pkg/publish/multi.go 0.00% 7 Missing ⚠️
pkg/commands/publisher.go 0.00% 3 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (52.02%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   52.42%   52.02%   -0.40%     
==========================================
  Files          43       43              
  Lines        3325     3350      +25     
==========================================
  Hits         1743     1743              
- Misses       1353     1377      +24     
- Partials      229      230       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

imjasonh
imjasonh reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Honestly this is a smaller change than I expected! 🎉

pkg/publish/default.go
return err
}

if err := remote.CheckPushPermission(tag, d.keychain, d.t); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to handle d.insecure, unfortunately... 🤔

@yokishava yokishava mentioned this pull request Feb 27, 2023
Closed
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for push permissions before building
3 participants
@developer-guy @codecov-commenter @imjasonh