fix: pipelines remover always returned (empty) error

lkingland · lkingland · commit e67721620c1b · 2024-05-08T09:49:53.000+09:00
diff --git a/pkg/pipelines/tekton/pipelines_provider.go b/pkg/pipelines/tekton/pipelines_provider.go
@@ -406,8 +406,10 @@ func (pp *PipelinesProvider) removeClusterResources(ctx context.Context, f fn.Fu
 		}
 		errMsg += fmt.Sprintf("\n %v", e)
 	}
-
-	return errors.New(errMsg)
+	if errMsg != "" {
+		return errors.New(errMsg)
+	}
+	return nil
 }
 
 // watchPipelineRunProgress watches the progress of the input PipelineRun

Original file line number	Diff line number	Diff line change
`@@ -406,8 +406,10 @@ func (pp *PipelinesProvider) removeClusterResources(ctx context.Context, f fn.Fu`
`406`	`406`	`}`
`407`	`407`	`errMsg += fmt.Sprintf("\n %v", e)`
`408`	`408`	`}`
`409`		`-`
`410`		`- return errors.New(errMsg)`
	`409`	`+ if errMsg != "" {`
	`410`	`+ return errors.New(errMsg)`
	`411`	`+ }`
	`412`	`+ return nil`
`411`	`413`	`}`
`412`	`414`
`413`	`415`	`// watchPipelineRunProgress watches the progress of the input PipelineRun`