Fix detection of hostname resolution failure

matejvasek · matejvasek · commit 317e8a04970c · 2025-05-26T19:43:17.000+02:00
It appears that newer version of docker outputs different error when
registry hostname is not resolvable.

Signed-off-by: Matej Vašek &lt;mvasek@redhat.com&gt;
diff --git a/pkg/docker/pusher.go b/pkg/docker/pusher.go
@@ -202,7 +202,9 @@ func (n *Pusher) pushImage(ctx context.Context, f fn.Function, credentials Crede
 		return digest, nil
 	}
 	errStr := err.Error()
-	if strings.Contains(errStr, "no such host") || strings.Contains(errStr, "failure in name resolution") {
+	if strings.Contains(errStr, "no such host") ||
+		strings.Contains(errStr, "failure in name resolution") ||
+		regexp.MustCompile(`lookup .*: server misbehaving`).MatchString(errStr) {
 		// push with custom transport to be able to push into cluster private registries
 		return n.push(ctx, f, credentials, output)
 	}

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,9 @@ func (n *Pusher) pushImage(ctx context.Context, f fn.Function, credentials Crede`
`202`	`202`	`return digest, nil`
`203`	`203`	`}`
`204`	`204`	`errStr := err.Error()`
`205`		`- if strings.Contains(errStr, "no such host") \|\| strings.Contains(errStr, "failure in name resolution") {`
	`205`	`+ if strings.Contains(errStr, "no such host") \|\|`
	`206`	`+ strings.Contains(errStr, "failure in name resolution") \|\|`
	`207`	+ regexp.MustCompile(`lookup .*: server misbehaving`).MatchString(errStr) {
`206`	`208`	`// push with custom transport to be able to push into cluster private registries`
`207`	`209`	`return n.push(ctx, f, credentials, output)`
`208`	`210`	`}`