fix(ButtonPrimitive): loading glyph is hidden from screen readers

DSil · DSil · commit cf82360adf7c · 2025-03-19T11:02:30.000+01:00
diff --git a/packages/orbit-components/src/primitives/ButtonPrimitive/index.tsx b/packages/orbit-components/src/primitives/ButtonPrimitive/index.tsx
@@ -221,7 +221,7 @@ const ButtonPrimitive = React.forwardRef<HTMLButtonElement | HTMLAnchorElement,
         )}
         style={varsButton}
       >
-        {loading && <Loading type="buttonLoader" />}
+        {loading && <Loading ariaHidden type="buttonLoader" />}
 
         {iconLeft != null && (
           <div
diff --git a/packages/orbit-components/src/primitives/Primitives.stories.tsx b/packages/orbit-components/src/primitives/Primitives.stories.tsx
@@ -153,7 +153,7 @@ export const ButtonPrimitive: Story = {
     role: "",
     spaceAfter: SPACINGS_AFTER.SMALL,
     submit: false,
-    title: "",
+    title: "Button title",
     tabIndex: 0,
     width: "",
     contentAlign: "center",

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ const ButtonPrimitive = React.forwardRef<HTMLButtonElement \| HTMLAnchorElement,`
`221`	`221`	`)}`
`222`	`222`	`style={varsButton}`
`223`	`223`	`>`
`224`		`- {loading && <Loading type="buttonLoader" />}`
	`224`	`+ {loading && <Loading ariaHidden type="buttonLoader" />}`
`225`	`225`
`226`	`226`	`{iconLeft != null && (`
`227`	`227`	`<div`