Skip to content

Commit 2526c13

Browse files
committed
feat(InputField): remove helpClosable prop
BREAKING CHANGE: The InputField component no longer accepts the helpClosable prop, since the help tooltip no longer renders the Close button.
1 parent c0b7ef6 commit 2526c13

File tree

4 files changed

+0
-6
lines changed

4 files changed

+0
-6
lines changed

packages/orbit-components/src/InputField/InputField.stories.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ const meta: Meta<InputFieldPropsAndCustomArgs> = {
4444
type: TYPE_OPTIONS.TEXT,
4545
disabled: false,
4646
readOnly: false,
47-
helpClosable: true,
4847
},
4948

5049
argTypes: {
@@ -93,7 +92,6 @@ export const DefaultInput: Story = {
9392
"spaceAfter",
9493
"prefix",
9594
"suffix",
96-
"helpClosable",
9795
],
9896
},
9997
},

packages/orbit-components/src/InputField/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ The table below contains all types of props available in the InputField componen
5555
| tabIndex | `string \| number` | | Specifies the tab order of an element. |
5656
| **type** | [`enum`](#enum) | `"text"` | The type of the InputField. |
5757
| value | `string \| number` | | Specifies the value of the InputField. To be used with controlled usage. |
58-
| helpClosable | `boolean` | `true` | Whether to display help as a closable tooltip, or have it open only while the field is focused. |
5958
| list | `string` | | The id of the datalist element. |
6059
| ariaAutocomplete | `inline \| list \| both` | | The aria-autocomplete attribute of the input, see [this docs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-autocomplete). |
6160
| role | `textbox \| combobox \| searchbox` | `textbox` | The role attribute of the input, see [this docs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/textbox_role). |

packages/orbit-components/src/InputField/index.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ const InputField = React.forwardRef<HTMLInputElement, Props>((props, ref) => {
102102
maxLength,
103103
suffix,
104104
help,
105-
helpClosable = true,
106105
value,
107106
defaultValue,
108107
tags,
@@ -310,7 +309,6 @@ const InputField = React.forwardRef<HTMLInputElement, Props>((props, ref) => {
310309
help={help}
311310
id={`${inputId}-feedback`}
312311
shown={shown}
313-
helpClosable={helpClosable}
314312
onShown={setTooltipShown}
315313
error={error}
316314
inlineLabel={inlineLabel}

packages/orbit-components/src/InputField/types.d.ts

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ export interface Props extends Common.Globals, Common.SpaceAfter, Common.DataAtt
4141
readonly autoFocus?: boolean;
4242
readonly id?: string;
4343
readonly insideInputGroup?: boolean;
44-
readonly helpClosable?: boolean;
4544
readonly onChange?: React.ChangeEventHandler<HTMLInputElement>;
4645
readonly onFocus?: React.FocusEventHandler<HTMLInputElement>;
4746
readonly onBlur?: React.FocusEventHandler<HTMLInputElement>;

0 commit comments

Comments
 (0)