Skip to content

Commit 84380c1

Browse files
authored
Merge pull request kubernetes-retired#660 from TommyLike/bug/fix_sub_error
Fix Resource Sub exception in Reclaim&Preempt Actions
2 parents 61e423c + 17403b4 commit 84380c1

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

pkg/scheduler/actions/preempt/preempt.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,9 @@ func preempt(
238238
}
239239
preempted.Add(preemptee.Resreq)
240240
// If reclaimed enough resources, break loop to avoid Sub panic.
241-
if resreq.LessEqual(preemptee.Resreq) {
241+
if resreq.LessEqual(preempted) {
242242
break
243243
}
244-
resreq.Sub(preemptee.Resreq)
245244
}
246245

247246
metrics.RegisterPreemptionAttempts()

pkg/scheduler/actions/reclaim/reclaim.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,9 @@ func (alloc *reclaimAction) Execute(ssn *framework.Session) {
164164
}
165165
reclaimed.Add(reclaimee.Resreq)
166166
// If reclaimed enough resources, break loop to avoid Sub panic.
167-
if resreq.LessEqual(reclaimee.Resreq) {
167+
if resreq.LessEqual(reclaimed) {
168168
break
169169
}
170-
resreq.Sub(reclaimee.Resreq)
171170
}
172171

173172
glog.V(3).Infof("Reclaimed <%v> for task <%s/%s> requested <%v>.",

0 commit comments

Comments
 (0)