Skip to content

Commit f43fcd2

Browse files
Removed extra 'ip addr del' on the lo inteface
The 'post-up ip addr del 127.0.0.1/8 dev lo' was thought to be required when the loopback interface subnet mask was narrowed from /8 to /16. After testing first reboot, subsequent reboots, config reloads, and systemctl restart networking on linecards and supevisors (DNX VOQ chassis), this cleanup command does not appear to be required. As such, this change removes it as well as reverts sonic-net#15080.
1 parent bdc1d7a commit f43fcd2

19 files changed

+0
-38
lines changed

files/image_config/interfaces/interfaces.j2

-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ iface lo inet loopback
2525
address 127.0.0.1
2626
netmask 255.255.0.0
2727
scope host
28-
post-up ip addr del 127.0.0.1/8 dev lo
29-
down ip addr add 127.0.0.1/8 dev lo
3028
{% endblock loopback %}
3129
{% block mgmt_interface %}
3230

src/sonic-config-engine/tests/sample_output/py2/interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband_ip

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_ip

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ iface lo inet loopback
1818
address 127.0.0.1
1919
netmask 255.255.0.0
2020
scope host
21-
post-up ip addr del 127.0.0.1/8 dev lo
22-
down ip addr add 127.0.0.1/8 dev lo
2321

2422
# The management network interface
2523
auto eth0

src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces_nomgmt

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ iface lo inet loopback
1818
address 127.0.0.1
1919
netmask 255.255.0.0
2020
scope host
21-
post-up ip addr del 127.0.0.1/8 dev lo
22-
down ip addr add 127.0.0.1/8 dev lo
2321

2422
# The management network interface
2523
auto eth0

src/sonic-config-engine/tests/sample_output/py2/two_mgmt_interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth1

src/sonic-config-engine/tests/sample_output/py3/interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband_ip

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_ip

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ iface lo inet loopback
1818
address 127.0.0.1
1919
netmask 255.255.0.0
2020
scope host
21-
post-up ip addr del 127.0.0.1/8 dev lo
22-
down ip addr add 127.0.0.1/8 dev lo
2321

2422
# The management network interface
2523
auto eth0

src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces_nomgmt

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ iface lo inet loopback
1818
address 127.0.0.1
1919
netmask 255.255.0.0
2020
scope host
21-
post-up ip addr del 127.0.0.1/8 dev lo
22-
down ip addr add 127.0.0.1/8 dev lo
2321

2422
# The management network interface
2523
auto eth0

src/sonic-config-engine/tests/sample_output/py3/two_mgmt_interfaces

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ iface lo inet loopback
99
address 127.0.0.1
1010
netmask 255.255.0.0
1111
scope host
12-
post-up ip addr del 127.0.0.1/8 dev lo
13-
down ip addr add 127.0.0.1/8 dev lo
1412

1513
# The management network interface
1614
auto eth0

0 commit comments

Comments
 (0)