updated rector config

Author: cappuc

composer.json

@@ -28,8 +28,8 @@
     },
     "require-dev": {
         "dereuromark/composer-prefer-lowest": "^0.1.10",
-        "larastan/larastan": "^2.8.1",
-        "laravel/pint": "^1.0",
+        "larastan/larastan": "^2.9",
+        "laravel/pint": "^1.17",
         "mockery/mockery": "^1.6",
         "nesbot/carbon": "^2.63 || ^3.0",
         "nunomaduro/collision": "^7.0 || ^8.0",
@@ -39,7 +39,7 @@
         "phpstan/extension-installer": "^1.1",
         "phpstan/phpstan-deprecation-rules": "^1.0",
         "phpstan/phpstan-phpunit": "^1.0",
-        "rector/rector": "^1.0",
+        "rector/rector": "^1.2",
         "spatie/invade": "^2.0",
         "spatie/laravel-data": "^4.3",
         "spatie/laravel-ray": "^1.26",

rector.php

@@ -2,15 +2,9 @@
 
 declare(strict_types=1);
 
-use Rector\CodeQuality\Rector\Array_\CallableThisArrayToAnonymousFunctionRector;
 use Rector\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiveTypeRector;
-use Rector\CodingStyle\Rector\ArrowFunction\StaticArrowFunctionRector;
-use Rector\CodingStyle\Rector\Closure\StaticClosureRector;
-use Rector\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\PropertyProperty\RemoveNullPropertyInitializationRector;
-use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
-use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 use Rector\Php70\Rector\StmtsAwareInterface\IfIssetToCoalescingRector;
 use Rector\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector;
 use Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector;
@@ -19,25 +13,31 @@
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector;
 
 return RectorConfig::configure()
-    ->withPhpSets()
-    ->withPreparedSets()
+    ->withCache(__DIR__.'/build/rector')
     ->withPaths([
         __DIR__.'/src',
         __DIR__.'/config',
     ])
+    ->withPhpSets()
+    ->withPreparedSets(
+        deadCode: true,
+        codeQuality: true,
+        codingStyle: true,
+        typeDeclarations: true,
+    )
+    ->withImportNames(
+        importNames: false,
+        importDocBlockNames: false,
+        importShortClasses: false,
+        removeUnusedImports: true
+    )
     ->withSkip([
         AddArrowFunctionReturnTypeRector::class,
         AddParamBasedOnParentClassMethodRector::class,
-        CallableThisArrayToAnonymousFunctionRector::class,
-        ChangeAndIfToEarlyReturnRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,
         IfIssetToCoalescingRector::class,
-        PostIncDecToPreIncDecRector::class,
         RemoveNullPropertyInitializationRector::class,
-        ReturnBinaryOrToEarlyReturnRector::class,
         ReturnTypeFromReturnDirectArrayRector::class,
         ReturnTypeFromReturnNewRector::class,
         ReturnTypeFromStrictTypedCallRector::class,
-        StaticArrowFunctionRector::class,
-        StaticClosureRector::class,
     ]);

src/Exceptions/TemporalSerializerException.php

@@ -8,11 +8,11 @@ class TemporalSerializerException extends Exception
 {
     public static function targetClassDoesntExists(string $className): self
     {
-        return new self("Cannot deserialize value, class `$className` does not exist");
+        return new self(sprintf('Cannot deserialize value, class `%s` does not exist', $className));
     }
 
     public static function targetClassIsNotSerializable(string $className): self
     {
-        return new self("Cannot deserialize value, class `$className` does not implement `TemporalSerializable` interface");
+        return new self(sprintf('Cannot deserialize value, class `%s` does not implement `TemporalSerializable` interface', $className));
     }
 }

src/Temporal.php

@@ -38,7 +38,7 @@ public function newChildWorkflow(): ChildWorkflowBuilder
 
     public function buildWorkerOptions(string $taskQueue): WorkerOptions
     {
-        if (static::$buildWorkerOptionsCallback) {
+        if (static::$buildWorkerOptionsCallback !== null) {
             $workerOptions = call_user_func(static::$buildWorkerOptionsCallback, $taskQueue);
 
             if ($workerOptions instanceof WorkerOptions) {