fix: Fix boolean handling bug in sqlite (#5003)

skynetigor · web-flow · commit e69b703163f9 · 2025-06-10T16:22:19.000+02:00
diff --git a/keep/api/core/cel_to_sql/sql_providers/mysql.py b/keep/api/core/cel_to_sql/sql_providers/mysql.py
@@ -33,6 +33,7 @@ def cast(self, expression_to_cast: str, to_type, force=False):
                 f"LOWER({expression_to_cast}) = 'true'": "TRUE",
                 f"LOWER({expression_to_cast}) = 'false'": "FALSE",
                 f"CAST({expression_to_cast} AS SIGNED) >= 1": "TRUE",
+                f"CAST({expression_to_cast} AS SIGNED) <= 1": "FALSE",
                 f"{expression_to_cast} != ''": "TRUE",
             }
             result = " ".join(
diff --git a/keep/api/core/cel_to_sql/sql_providers/postgresql.py b/keep/api/core/cel_to_sql/sql_providers/postgresql.py
@@ -44,7 +44,7 @@ def cast(self, expression_to_cast: str, to_type: DataType, force=False):
                 f"LOWER({expression_to_cast}) = 'true'": "true",
                 f"LOWER({expression_to_cast}) = 'false'": "false",
                 # regex match ensures safe casting to float
-                f"{expression_to_cast} ~ '^[-+]?[0-9]*\\.?[0-9]+$' AND CAST({expression_to_cast} AS FLOAT) >= 1": "true",
+                f"{expression_to_cast} ~ '^[-+]?[0-9]*\\.?[0-9]+$'": f"CAST({expression_to_cast} AS FLOAT) >= 1",
                 f"LOWER({expression_to_cast}) != ''": "true",
             }
             result = " ".join(
diff --git a/keep/api/core/cel_to_sql/sql_providers/sqlite.py b/keep/api/core/cel_to_sql/sql_providers/sqlite.py
@@ -77,6 +77,7 @@ def cast(self, expression_to_cast: str, to_type: DataType, force=False):
                 f"LOWER({expression_to_cast}) = 'true'": "TRUE",
                 f"LOWER({expression_to_cast}) = 'false'": "FALSE",
                 f"CAST({expression_to_cast} AS SIGNED) >= 1": "TRUE",
+                f"CAST({expression_to_cast} AS SIGNED) <= 1": "FALSE",
                 f"{expression_to_cast} != ''": "TRUE",
             }
             result = " ".join(
diff --git a/tests/cel_to_sql/cel-to-sql-test-cases.json b/tests/cel_to_sql/cel-to-sql-test-cases.json
@@ -12,9 +12,9 @@
     "input_cel": "booleanFromJson == true",
     "description": "Equality with boolean from JSON",
     "expected_sql_dialect_based": {
-      "mysql": "CASE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'true' THEN TRUE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'false' THEN FALSE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) >= 1 THEN TRUE WHEN JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) != '' THEN TRUE ELSE FALSE END = TRUE",
-      "postgresql": "CASE WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'true' THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'false' THEN false WHEN (alert_event) ->> 'booleanFromJson' ~ '^[-+]?[0-9]*\\.?[0-9]+$' AND CAST((alert_event) ->> 'booleanFromJson' AS FLOAT) >= 1 THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') != '' THEN true ELSE false END = true",
-      "sqlite": "CASE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'true' THEN TRUE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'false' THEN FALSE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) >= 1 THEN TRUE WHEN json_extract(alert_event, '$.\"booleanFromJson\"') != '' THEN TRUE ELSE FALSE END = true"
+      "mysql": "CASE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'true' THEN TRUE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'false' THEN FALSE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) >= 1 THEN TRUE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) <= 1 THEN FALSE WHEN JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) != '' THEN TRUE ELSE FALSE END = TRUE",
+      "postgresql": "CASE WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'true' THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'false' THEN false WHEN (alert_event) ->> 'booleanFromJson' ~ '^[-+]?[0-9]*\\.?[0-9]+$' THEN CAST((alert_event) ->> 'booleanFromJson' AS FLOAT) >= 1 WHEN LOWER((alert_event) ->> 'booleanFromJson') != '' THEN true ELSE false END = true",
+      "sqlite": "CASE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'true' THEN TRUE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'false' THEN FALSE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) >= 1 THEN TRUE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) <= 1 THEN FALSE WHEN json_extract(alert_event, '$.\"booleanFromJson\"') != '' THEN TRUE ELSE FALSE END = true"
     }
   },
   {
@@ -57,9 +57,9 @@
     "input_cel": "booleanFromJson in [true,false]",
     "description": "IN operator along with boolean from JSON",
     "expected_sql_dialect_based": {
-      "mysql": "CASE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'true' THEN TRUE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'false' THEN FALSE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) >= 1 THEN TRUE WHEN JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) != '' THEN TRUE ELSE FALSE END in (TRUE, FALSE)",
-      "postgresql": "CASE WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'true' THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'false' THEN false WHEN (alert_event) ->> 'booleanFromJson' ~ '^[-+]?[0-9]*\\.?[0-9]+$' AND CAST((alert_event) ->> 'booleanFromJson' AS FLOAT) >= 1 THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') != '' THEN true ELSE false END in (true, false)",
-      "sqlite": "CASE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'true' THEN TRUE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'false' THEN FALSE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) >= 1 THEN TRUE WHEN json_extract(alert_event, '$.\"booleanFromJson\"') != '' THEN TRUE ELSE FALSE END in (true, false)"
+      "mysql": "CASE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'true' THEN TRUE WHEN LOWER(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"'))) = 'false' THEN FALSE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) >= 1 THEN TRUE WHEN CAST(JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) AS SIGNED) <= 1 THEN FALSE WHEN JSON_UNQUOTE(JSON_EXTRACT(alert_event, '$.\"booleanFromJson\"')) != '' THEN TRUE ELSE FALSE END in (TRUE, FALSE)",
+      "postgresql": "CASE WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'true' THEN true WHEN LOWER((alert_event) ->> 'booleanFromJson') = 'false' THEN false WHEN (alert_event) ->> 'booleanFromJson' ~ '^[-+]?[0-9]*\\.?[0-9]+$' THEN CAST((alert_event) ->> 'booleanFromJson' AS FLOAT) >= 1 WHEN LOWER((alert_event) ->> 'booleanFromJson') != '' THEN true ELSE false END in (true, false)",
+      "sqlite": "CASE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'true' THEN TRUE WHEN LOWER(json_extract(alert_event, '$.\"booleanFromJson\"')) = 'false' THEN FALSE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) >= 1 THEN TRUE WHEN CAST(json_extract(alert_event, '$.\"booleanFromJson\"') AS SIGNED) <= 1 THEN FALSE WHEN json_extract(alert_event, '$.\"booleanFromJson\"') != '' THEN TRUE ELSE FALSE END in (true, false)"
     }
   },
   {

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ def cast(self, expression_to_cast: str, to_type, force=False):`
`33`	`33`	`f"LOWER({expression_to_cast}) = 'true'": "TRUE",`
`34`	`34`	`f"LOWER({expression_to_cast}) = 'false'": "FALSE",`
`35`	`35`	`f"CAST({expression_to_cast} AS SIGNED) >= 1": "TRUE",`
	`36`	`+ f"CAST({expression_to_cast} AS SIGNED) <= 1": "FALSE",`
`36`	`37`	`f"{expression_to_cast} != ''": "TRUE",`
`37`	`38`	`}`
`38`	`39`	`result = " ".join(`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def cast(self, expression_to_cast: str, to_type: DataType, force=False):`
`44`	`44`	`f"LOWER({expression_to_cast}) = 'true'": "true",`
`45`	`45`	`f"LOWER({expression_to_cast}) = 'false'": "false",`
`46`	`46`	`# regex match ensures safe casting to float`
`47`		`- f"{expression_to_cast} ~ '^[-+]?[0-9]*\\.?[0-9]+$' AND CAST({expression_to_cast} AS FLOAT) >= 1": "true",`
	`47`	`+ f"{expression_to_cast} ~ '^[-+]?[0-9]*\\.?[0-9]+$'": f"CAST({expression_to_cast} AS FLOAT) >= 1",`
`48`	`48`	`f"LOWER({expression_to_cast}) != ''": "true",`
`49`	`49`	`}`
`50`	`50`	`result = " ".join(`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@ def cast(self, expression_to_cast: str, to_type: DataType, force=False):`
`77`	`77`	`f"LOWER({expression_to_cast}) = 'true'": "TRUE",`
`78`	`78`	`f"LOWER({expression_to_cast}) = 'false'": "FALSE",`
`79`	`79`	`f"CAST({expression_to_cast} AS SIGNED) >= 1": "TRUE",`
	`80`	`+ f"CAST({expression_to_cast} AS SIGNED) <= 1": "FALSE",`
`80`	`81`	`f"{expression_to_cast} != ''": "TRUE",`
`81`	`82`	`}`
`82`	`83`	`result = " ".join(`