Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backoff when receive rate limit errors in the Github scaler #6643

Open
andrewhibbert opened this issue Mar 24, 2025 · 0 comments · May be fixed by #6644
Open

Implement backoff when receive rate limit errors in the Github scaler #6643

andrewhibbert opened this issue Mar 24, 2025 · 0 comments · May be fixed by #6644
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@andrewhibbert
Copy link
Contributor

Proposal

The best practices suggest to handle rate limit errors appropriately, in particular:

  • If the retry-after response header is present, you should not retry your request until after that many seconds has elapsed.
  • If the x-ratelimit-remaining header is 0, you should not make another request until after the time specified by the x-ratelimit-reset header. The x-ratelimit-reset header is in UTC epoch seconds.

Use-Case

Continuing to make requests while you are rate limited may result in the banning of your integration.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@andrewhibbert andrewhibbert added feature-request All issues for new features that have not been committed to needs-discussion labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: To Triage
Development

Successfully merging a pull request may close this issue.

1 participant