Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SolarWinds Scaler #6576

Open
gantrior opened this issue Feb 28, 2025 · 8 comments · May be fixed by #6577 or kedacore/keda-docs#1545
Open

Support SolarWinds Scaler #6576

gantrior opened this issue Feb 28, 2025 · 8 comments · May be fixed by #6577 or kedacore/keda-docs#1545

Comments

@gantrior
Copy link

Proposal

The solarwinds scaler allows the users to integrate KEDA with SolarWinds Observability and its data, allowing to autoscale on metrics that are collected by SWO K8s Collector and sent to SolarWinds Observability

Scaler Source

SolarWinds Observability Metrics

Scaling Mechanics

Based on data returned from metrics of https://www.solarwinds.com/solarwinds-observability

Authentication Source

API Token

Anything else?

No response

@gantrior
Copy link
Author

gantrior commented Mar 3, 2025

@JorTurFer
Copy link
Member

I think that this is nice! Does SolarWinds observability offer a free tier that we can use for e2e tests?

@gantrior
Copy link
Author

I think that this is nice! Does SolarWinds observability offer a free tier that we can use for e2e tests?

There is 30-days free trial that can be used for E2E test purposes if that is sufficient.

@zroubalik
Copy link
Member

I am concerned 30-days trieal is not enough. We need a permanent solution, we run these e2e tests during the lifetime of a scaler.

@gantrior
Copy link
Author

I am concerned 30-days trieal is not enough. We need a permanent solution, we run these e2e tests during the lifetime of a scaler.

We will create dedicated permanent tenant on staging environment for this purpose, we will just need to make sure that API_TOKEN that scaler will use to query measurements will be set as secret in CI for E2E test. Is this suitable option?

@JorTurFer
Copy link
Member

JorTurFer commented Mar 23, 2025

Hello
Yes, it'll be. We store secrets as GH secrets, so it won't be exposed on logs and it will be passed to e2e via env var. Is this enough?

Usually, we create/request a tenant for us, and we have an admin account on the tenant in order to manage issues and so on, checking the scaler and the upstream behavior (it doesn't mean that you can't be part of the tenant too), this helps because we as maintainers can help troubleshooting issues. If you provide access to us to that environment/tenant would be nice if we need to fix an issue or so, otherwise you will be the only people allowed to maintain the scaler (which is an option too if you are willing).

@gantrior
Copy link
Author

@JorTurFer Unfortunately, due to the nature of the SolarWinds Observability staging environment (lack of resource usage limits), we cannot provide direct admin access to these tenants to anyone outside of SolarWinds. However, the tenant is mostly empty; it contains only a single metric used by the E2E test to retrieve measurements, so there's not much to manage. Once SolarWinds Observability introduces a "free tier"-like option, we could switch to that on Prod, allowing you direct access. However, I cannot guarantee if or when that will happen.

Do you use keybase? If so, I could securely send you the SOLARWINDS_API_TOKEN and SOLARWINDS_API_URL values for CI/CD E2E testing purposes.

@zroubalik
Copy link
Member

zroubalik commented Mar 26, 2025

Do you use keybase? If so, I could securely send you the SOLARWINDS_API_TOKEN and SOLARWINDS_API_URL values for CI/CD E2E testing purposes.

I don't, maybe @JorTurFer does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Triage
3 participants