Skip to content
This repository was archived by the owner on Dec 1, 2021. It is now read-only.

Move DockerHub repo to kedacore #8

Open
2 of 3 tasks
TsuyoshiUshio opened this issue Jan 24, 2020 · 12 comments
Open
2 of 3 tasks

Move DockerHub repo to kedacore #8

TsuyoshiUshio opened this issue Jan 24, 2020 · 12 comments

Comments

@TsuyoshiUshio
Copy link
Collaborator

TsuyoshiUshio commented Jan 24, 2020

As a developer, I'd like to move the container image namespace from tsuyoshiushio to kedacore, so that people can see the image as official.

Success Criteria

  • docker image name is changed to kedacore
  • All Deployment Script / YAML file is modified and tested.
  • Create a Release pipeline to publish the docker image
@tomkerkhove
Copy link
Member

Opened a PR to update the image name, do you have a preference in terms of release pipeline or shall we align with kedacore/keda and use GitHub actions?

@TsuyoshiUshio
Copy link
Collaborator Author

Thank you for submitting PR. I've never used GitHub actions, however, I'm fine to move for it.

@tomkerkhove
Copy link
Member

I don't really have a preference to be honest, I myself use Azure DevOps for most of my projects.

@tomkerkhove
Copy link
Member

Happy to help where I can

@TsuyoshiUshio
Copy link
Collaborator Author

I merged your PR. Let's try GitHub actions this time. It might be easier for give permission for the contributors.

@tomkerkhove
Copy link
Member

Happy to help if I can

@tomkerkhove
Copy link
Member

What process are you looking at for the release?

  1. Build image
  2. Push image

Or do you have tests to run already?

@TsuyoshiUshio
Copy link
Collaborator Author

TsuyoshiUshio commented Jan 29, 2020

I appreciate your help! Ideally, If we create a tag, the pipeline works and push the image would be great. Before pushing, Could you run the C# based test? You can refer the C# based test on azure-pipeline.yml on this repo.

@tomkerkhove
Copy link
Member

Sounds good to me, I can take a crack at that.

@tomkerkhove
Copy link
Member

Do you already have the CI setup for azure-pipeline.yml on Azure DevOps? If so, let's just stick with that then.

@TsuyoshiUshio
Copy link
Collaborator Author

Yes. https://github.com/kedacore/keda-scaler-durable-functions/blob/master/azure-pipelines.yml this is the one I'm using on current Azure DevOps. You can see the execution in here. https://durabletaskframework.visualstudio.com/Durable%20Task%20Framework%20CI/_build/results?buildId=873&view=results Unfortunately, it is public but under the Microsoft Internal Subscription.

@tomkerkhove
Copy link
Member

Then I'll draft up a DevOps YAML to align with that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants