Add test for API version upgrades

Author: willthames

kustomize/resource_kustomization_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"regexp"
+	"strings"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -370,6 +371,52 @@ resource "kustomization_resource" "ss" {
 `
 }
 
+//
+//
+// Upgrade_API_Version Test
+func TestAccResourceKustomization_upgradeAPIVersion(t *testing.T) {
+
+	resource.Test(t, resource.TestCase{
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			//
+			//
+			// Applying initial networking.k8s.io/v1beta1 ingress
+			{
+				Config: testAccResourceKustomizationConfig_upgradeAPIVersion("test_kustomizations/upgrade_api_version/initial"),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrSet("kustomization_resource.ns", "id"),
+					resource.TestCheckResourceAttrSet("kustomization_resource.ing", "id"),
+					testAccCheckManifestNestedString("kustomization_resource.ing", "networking.k8s.io/v1beta1", "apiVersion"),
+				),
+			},
+			//
+			//
+			// Update ingress to networking.k8s.io/v1
+			{
+				Config: testAccResourceKustomizationConfig_upgradeAPIVersion("test_kustomizations/upgrade_api_version/modified"),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrSet("kustomization_resource.ns", "id"),
+					resource.TestCheckResourceAttrSet("kustomization_resource.ing", "id"),
+					testAccCheckManifestNestedString("kustomization_resource.ing", "networking.k8s.io/v1", "apiVersion"),
+				),
+			},
+		},
+	})
+}
+
+func testAccResourceKustomizationConfig_upgradeAPIVersion(path string) string {
+	return testAccDataSourceKustomizationConfig_basic(path) + `
+resource "kustomization_resource" "ns" {
+	manifest = data.kustomization_build.test.manifests["~G_~V_Namespace|~X|test-upgrade-api-version"]
+}
+
+resource "kustomization_resource" "ing" {
+	manifest = data.kustomization_build.test.manifests["networking.k8s.io_~V_Ingress|test-upgrade-api-version|test-upgrade-api-version"]
+}
+`
+}
+
 //
 //
 // CRD Test
@@ -795,3 +842,33 @@ func testAccCheckManifestSelectorAbsent(n string, k string) resource.TestCheckFu
 		return nil
 	}
 }
+
+func testAccCheckManifestNestedString(n string, expected string, k ...string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		u, err := getResourceFromTestState(s, n)
+		if err != nil {
+			return err
+		}
+
+		resp, err := getResourceFromK8sAPI(u)
+		if err != nil {
+			return err
+		}
+
+		k8spath := strings.Join(k, ".")
+
+		actual, ok, err := k8sunstructured.NestedString(resp.Object, k...)
+		if !ok {
+			return fmt.Errorf("%s missing from resource %s", k8spath, n)
+		}
+		if err != nil {
+			return err
+		}
+
+		if actual != expected {
+			return fmt.Errorf("value %s of %s does not match expected %s", actual, k8spath, expected)
+		}
+
+		return nil
+	}
+}

kustomize/test_kustomizations/upgrade_api_version/initial/ingress.yaml

@@ -0,0 +1,20 @@
+apiVersion: networking.k8s.io/v1beta1
+kind: Ingress
+metadata:
+  labels:
+    app: test-upgrade-api-version
+  name: test-upgrade-api-version
+  namespace: test-upgrade-api-version
+spec:
+  rules:
+  - host: test-upgrade-api-version.example.com
+    http:
+      paths:
+      - backend:
+          serviceName: test-upgrade-api-version
+          servicePort: 80
+        path: /
+  tls:
+  - hosts:
+    - test-upgrade-api-version.example.com
+    secretName: test-upgrade-api-version-tls-internal

kustomize/test_kustomizations/upgrade_api_version/initial/kustomization.yaml

@@ -0,0 +1,8 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+namespace: test-upgrade-api-version
+
+resources:
+- namespace.yaml
+- ingress.yaml

kustomize/test_kustomizations/upgrade_api_version/initial/namespace.yaml

@@ -0,0 +1,4 @@
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: test-upgrade-api-version

kustomize/test_kustomizations/upgrade_api_version/modified/ingress.yaml

@@ -0,0 +1,23 @@
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  labels:
+    app: test-upgrade-api-version
+  name: test-upgrade-api-version
+  namespace: test-upgrade-api-version
+spec:
+  rules:
+  - host: test-upgrade-api-version.example.com
+    http:
+      paths:
+      - backend:
+          service:
+            name: test-upgrade-api-version
+            port:
+              number: 80
+        path: /
+        pathType: ImplementationSpecific
+  tls:
+  - hosts:
+    - test-upgrade-api-version.example.com
+    secretName: test-upgrade-api-version-tls-internal

kustomize/test_kustomizations/upgrade_api_version/modified/kustomization.yaml

@@ -0,0 +1,8 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+
+namespace: test-upgrade-api-version
+
+resources:
+- namespace.yaml
+- ingress.yaml

kustomize/test_kustomizations/upgrade_api_version/modified/namespace.yaml

@@ -0,0 +1,4 @@
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: test-upgrade-api-version