Skip to content

Implement proper column versions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
15 tasks
karoliskoncevicius opened this issue Jul 5, 2019 · 0 comments
Open
15 tasks

Implement proper column versions #6

karoliskoncevicius opened this issue Jul 5, 2019 · 0 comments
Assignees
Labels

Comments

@karoliskoncevicius
Copy link
Owner

karoliskoncevicius commented Jul 5, 2019

Currently the col_ versions of all tests transpose the inputs and call row_ functions.

This behaviour is undesirable because of at least three reasons:

  1. Transposing inputs takes time.
  2. col-wise functions (like colMeans) are typically faster than their row equivalents
  3. When inputs have different lengths the functions might throw a warning about rows.
  • row_t_onesample(x)
  • row_t_welch(x, y)
  • row_t_equalvar(x, y)
  • row_t_paired(x, y)
  • row_wilcoxon_onesample(x)
  • row_wilcoxon_twosample(x, y)
  • row_wilcoxon_paired(x, y)
  • row_cor_pearson(x, y)
  • row_oneway_welch(x, g)
  • row_oneway_equalvar(x, g)
  • row_kruskalwallis(x, g)
  • row_f_var(x, y)
  • row_bartlett(x, g)
  • row_flignerkilleen(x, g)
  • row_jarquebera(x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant