Skip to content

Commit 2432d88

Browse files
authored
Merge pull request #138 from zmstone/pin-kafka-docker-image-version-1.1.2
test: use latest Kafka docker image version
2 parents a5755ce + 1a26034 commit 2432d88

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
export KAFKA_IMAGE_VERSION ?= 1.1.2
12
export KAFKA_VERSION ?= 4.0.0
23
all: compile
34

scripts/docker-compose-4.yml renamed to scripts/docker-compose-kraft.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
kafka_1:
3-
image: "zmstone/kafka:1.1-${KAFKA_VERSION}"
3+
image: ${KAFKA_IMAGE_TAG}
44
container_name: 'kafka-1'
55
ports:
66
- "9092:9092"
@@ -19,7 +19,7 @@ services:
1919
INNER_HOSTNAME: kafka-1
2020
VOTERS: "1@kafka-1:9090,2@kafka-2:9090"
2121
kafka_2:
22-
image: "zmstone/kafka:1.1-${KAFKA_VERSION}"
22+
image: ${KAFKA_IMAGE_TAG}
2323
container_name: 'kafka-2'
2424
ports:
2525
- "9192:9192"

scripts/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
services:
22
zookeeper:
3-
image: "zmstone/kafka:1.1-${KAFKA_VERSION}"
3+
image: ${KAFKA_IMAGE_TAG}
44
container_name: zookeeper
55
command: run zookeeper
66
network_mode: host
77
kafka_1:
88
depends_on:
99
- zookeeper
10-
image: "zmstone/kafka:1.1-${KAFKA_VERSION}"
10+
image: ${KAFKA_IMAGE_TAG}
1111
container_name: 'kafka-1'
1212
network_mode: host
1313
environment:
@@ -21,7 +21,7 @@ services:
2121
kafka_2:
2222
depends_on:
2323
- zookeeper
24-
image: "zmstone/kafka:1.1-${KAFKA_VERSION}"
24+
image: ${KAFKA_IMAGE_TAG}
2525
container_name: 'kafka-2'
2626
network_mode: host
2727
environment:

scripts/setup-test-env.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ docker ps > /dev/null || {
66
exit 1
77
}
88

9-
VERSION=${KAFKA_VERSION:-4.0.0}
10-
if [ -z $VERSION ]; then VERSION=$1; fi
9+
KAFKA_IMAGE_VERSION="${KAFKA_IMAGE_VERSION:-1.1.2}"
10+
VERSION="${KAFKA_VERSION:-${1:-4.0.0}}"
1111

1212
case $VERSION in
1313
0.9*)
@@ -37,8 +37,9 @@ case $VERSION in
3737
;;
3838
esac
3939

40-
echo "Using KAFKA_VERSION=$VERSION"
4140
export KAFKA_VERSION=$VERSION
41+
export KAFKA_IMAGE_TAG="zmstone/kafka:${KAFKA_IMAGE_VERSION}-${KAFKA_VERSION}"
42+
echo "Using $KAFKA_IMAGE_TAG"
4243

4344
KAFKA_MAJOR=$(echo "$KAFKA_VERSION" | cut -d. -f1)
4445
if [ "$KAFKA_MAJOR" -lt 3 ]; then
@@ -56,12 +57,12 @@ fi
5657
TD="$(cd "$(dirname "$0")" && pwd)"
5758

5859
docker compose -f $TD/docker-compose.yml down || true
59-
docker compose -f $TD/docker-compose-4.yml down || true
60+
docker compose -f $TD/docker-compose-kraft.yml down || true
6061

6162
if [[ "$NEED_ZOOKEEPER" = true ]]; then
6263
docker compose -f $TD/docker-compose.yml up -d
6364
else
64-
docker compose -f $TD/docker-compose-4.yml up -d
65+
docker compose -f $TD/docker-compose-kraft.yml up -d
6566
fi
6667

6768
# give kafka some time

0 commit comments

Comments
 (0)