Merge pull request #4327 from makhov/external-etcd-shutdown

makhov · web-flow · commit 8b89fe721f34 · 2024-04-23T11:07:09.000+03:00
Fixed Stop() for external etcd
diff --git a/pkg/component/controller/etcd.go b/pkg/component/controller/etcd.go
@@ -230,6 +230,10 @@ func (e *Etcd) Start(ctx context.Context) error {
 
 // Stop stops etcd
 func (e *Etcd) Stop() error {
+	if e.Config.IsExternalClusterUsed() {
+		return nil
+	}
+
 	return e.supervisor.Stop()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,10 @@ func (e *Etcd) Start(ctx context.Context) error {`
`230`	`230`
`231`	`231`	`// Stop stops etcd`
`232`	`232`	`func (e *Etcd) Stop() error {`
	`233`	`+ if e.Config.IsExternalClusterUsed() {`
	`234`	`+ return nil`
	`235`	`+ }`
	`236`	`+`
`233`	`237`	`return e.supervisor.Stop()`
`234`	`238`	`}`
`235`	`239`