TMP

Co-authored-by: Tom Wieczorek <[email protected]>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>

Author: juanluisvaladas

.golangci.yml

@@ -81,13 +81,14 @@ linters:
       template-path: .go-header.txt
     revive:
       rules:
+        # This forbids to name variables "close", which seems natural for "close" functions.
         - name: redefines-builtin-id
           disabled: true
     testifylint:
       enable-all: true
       disable:
-        - require-error
-        - suite-thelper
+        - require-error # flags too many legitimate use cases
+        - suite-thelper # flags too many legitimate use cases
   exclusions:
     generated: lax
     presets:

cmd/reset/reset.go

@@ -64,7 +64,7 @@ func (c *command) reset() error {
 
 	k0sStatus, _ := status.GetStatusInfo(c.K0sVars.StatusSocketPath)
 	if k0sStatus != nil && k0sStatus.Pid != 0 {
-		return errors.New("k0s seems to be running! please stop k0s before reset")
+		return errors.New("k0s seems to be running, please stop k0s before reset")
 	}
 
 	nodeCfg, err := c.K0sVars.NodeConfig()

pkg/component/controller/extensions_controller.go

@@ -323,10 +323,10 @@ func (cr *ChartReconciler) updateOrInstallChart(ctx context.Context, chart helmv
 }
 
 func (cr *ChartReconciler) chartNeedsUpgrade(chart helmv1beta1.Chart) bool {
-	return (chart.Status.Namespace != chart.Spec.Namespace ||
+	return chart.Status.Namespace != chart.Spec.Namespace ||
 		chart.Status.ReleaseName != chart.Spec.ReleaseName ||
 		chart.Status.Version != chart.Spec.Version ||
-		chart.Status.ValuesHash != chart.Spec.HashValues())
+		chart.Status.ValuesHash != chart.Spec.HashValues()
 }
 
 // updateStatus updates the status of the chart with the given release information. This function