Skip to content

Commit 079eb7c

Browse files
committed
Make calls to mktemp more portable
mktemp does not necessarily support the XXXXXX placeholder in the middle of the template string, so move all placeholder occurrences in template strings to the end. Adjust the gitignore file accordingly. Signed-off-by: Tom Wieczorek <[email protected]>
1 parent 2241665 commit 079eb7c

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
/k0s.exe.code
1111
/pkg/assets/zz_generated_offsets*.go
1212
.*.stamp
13-
.tmp
13+
*.tmp
14+
*.tmp.*
1415
.terraform
1516
.idea
1617
*.tfstate*
1718
aws_private.pem
18-
out.json
1919
.vscode
2020
.k0sbuild.docker-image.*
2121
docs/cli

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ controller_gen_targets := $(foreach gv,$(api_group_versions),pkg/apis/$(gv)/.con
132132
codegen_targets := $(controller_gen_targets)
133133
$(controller_gen_targets): $(K0S_BUILD_IMAGE_FILE) hack/tools/boilerplate.go.txt hack/tools/Makefile.variables
134134
rm -rf 'static/_crds/$(dir $(@:pkg/apis/%/.controller-gen.stamp=%))'
135-
gendir="$$(mktemp -d .controller-gen.XXXXXX.tmp)" \
135+
gendir="$$(mktemp -d .controller-gen.tmp.XXXXXX)" \
136136
&& trap "rm -rf -- $$gendir" INT EXIT \
137137
&& CGO_ENABLED=0 $(GO) run sigs.k8s.io/controller-tools/cmd/controller-gen@v$(controller-gen_version) \
138138
paths="./$(dir $@)..." \
@@ -160,7 +160,7 @@ clientset_input_dirs := $(foreach gv,$(api_group_versions),pkg/apis/$(gv))
160160
codegen_targets += pkg/client/clientset/.client-gen.stamp
161161
pkg/client/clientset/.client-gen.stamp: $(shell find $(clientset_input_dirs) -type f -name '*.go' -not -name '*_test.go' -not -name 'zz_generated*')
162162
pkg/client/clientset/.client-gen.stamp: $(K0S_BUILD_IMAGE_FILE) hack/tools/boilerplate.go.txt embedded-bins/Makefile.variables
163-
gendir="$$(mktemp -d .client-gen.XXXXXX.tmp)" \
163+
gendir="$$(mktemp -d .client-gen.tmp.XXXXXX)" \
164164
&& trap "rm -rf -- $$gendir" INT EXIT \
165165
&& CGO_ENABLED=0 $(GO) run k8s.io/code-generator/cmd/client-gen@v$(kubernetes_version:1.%=0.%) \
166166
--go-header-file=hack/tools/boilerplate.go.txt \

embedded-bins/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ $(bindir)/kubelet.exe $(bindir)/kube-proxy.exe: .container.kubernetes.windows
6565
$(bindir)/containerd.exe $(bindir)/containerd-shim-runhcs-v1.exe: .container.containerd.windows
6666

6767
$(addprefix $(bindir)/, $(bins)): | $(bindir)
68-
tardir=$$(mktemp -d -- '.$(notdir $@).XXXXXX.tmp') \
68+
tardir=$$(mktemp -d -- '.$(notdir $@).tmp.XXXXXX') \
6969
&& trap "rm -rf -- $$tardir" INT EXIT \
7070
&& docker export "$$(cat $<)" \
7171
| tar -C "$$tardir" -x bin/$(notdir $@) \

0 commit comments

Comments
 (0)