Skip to content

Commit dc2e4db

Browse files
fixed unit tests for buildRequestSite
1 parent 9aea3bc commit dc2e4db

File tree

2 files changed

+13
-17
lines changed

2 files changed

+13
-17
lines changed

modules/jwplayerBidAdapter.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ function buildRequest(bidRequest, bidderRequest) {
9393
const openrtbRequest = {
9494
id: bidRequest.bidId,
9595
imp: buildRequestImpression(bidRequest, bidderRequest),
96-
site: buildRequestSite(bidRequest),
96+
site: buildRequestSite(bidderRequest),
9797
device: buildRequestDevice()
9898
};
9999

@@ -170,15 +170,13 @@ function buildBidFloorData(bidRequest) {
170170
return floorData;
171171
}
172172

173-
function buildRequestSite(bidRequest) {
174-
/* eslint-disable no-console */
173+
function buildRequestSite(bidderRequest) {
175174
const site = config.getConfig('ortb2.site') || {};
176-
console.log(site);
177175

178176
site.domain = site.domain || config.publisherDomain || window.location.hostname;
179177
site.page = site.page || config.pageUrl || window.location.href;
180178

181-
const referer = bidRequest.refererInfo && bidRequest.refererInfo.referer;
179+
const referer = bidderRequest.refererInfo && bidderRequest.refererInfo.referer;
182180
if (!site.ref && referer) {
183181
site.ref = referer;
184182
}

test/spec/modules/jwplayerBidAdapter_spec.js

+10-12
Original file line numberDiff line numberDiff line change
@@ -61,20 +61,16 @@ describe('jwplayer adapter tests', function() {
6161
let sandbox = sinon.sandbox.create();
6262
sandbox.stub(config, 'getConfig').callsFake((key) => {
6363
const config = {
64-
'ortb2': {
65-
site: {
66-
domain: 'page.example.com',
67-
page: 'https://examplepage.com'
68-
}
64+
'ortb2.site': {
65+
domain: 'page.example.com',
66+
page: 'https://examplepage.com'
6967
}
7068
};
7169
return config[key];
72-
})
70+
});
7371

7472
const serverRequests = spec.buildRequests(bidRequests, this.defaultBidderRequest);
7573

76-
/* eslint-disable no-console */
77-
7874
serverRequests.forEach(serverRequest => {
7975
expect(serverRequest.url).to.have.string('https://ib.adnxs.com/openrtb2/prebid');
8076
expect(serverRequest.method).to.equal('POST');
@@ -87,11 +83,11 @@ describe('jwplayer adapter tests', function() {
8783
expect(openrtbRequest.site).to.not.equal(null);
8884
expect(openrtbRequest.site).to.be.an('object');
8985
expect(openrtbRequest.site.domain).to.be.a('string');
90-
expect(openrtbRequest.site.domain).to.equal('page.example.com');
86+
expect(openrtbRequest.site.domain).to.have.string('page.example.com');
9187
expect(openrtbRequest.site.page).to.be.a('string');
92-
expect(openrtbRequest.site.page).to.equal('https://examplepage.com');
88+
expect(openrtbRequest.site.page).to.have.string('https://examplepage.com');
9389
expect(openrtbRequest.site.ref).to.be.a('string');
94-
expect(openrtbRequest.site.ref).to.equal('https://example.com');
90+
expect(openrtbRequest.site.ref).to.have.string('https://example.com');
9591

9692
expect(openrtbRequest.device).to.not.equal(null);
9793
expect(openrtbRequest.device.ua).to.equal(navigator.userAgent);
@@ -111,7 +107,9 @@ describe('jwplayer adapter tests', function() {
111107
expect(openrtbRequest.regs.ext).to.not.equal(null);
112108
expect(openrtbRequest.regs.ext.gdpr).to.equal(1);
113109
expect(openrtbRequest.regs.ext.us_privacy).to.equal(true);
114-
})
110+
});
111+
112+
sandbox.restore();
115113
});
116114
});
117115

0 commit comments

Comments
 (0)