Skip to content

Commit 9595fc9

Browse files
nickjacobjorgeluisrocha
authored andcommitted
empty string adUnitId parameter is treated as missing (prebid#9071)
1 parent ef68b40 commit 9595fc9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

modules/amxBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ function convertRequest(bid) {
147147
const tid = deepAccess(bid, 'params.tagId');
148148

149149
const au =
150-
bid.params != null && typeof bid.params.adUnitId === 'string'
150+
bid.params != null && typeof bid.params.adUnitId === 'string' && bid.params.adUnitId !== ''
151151
? bid.params.adUnitId
152152
: bid.adUnitCode;
153153

test/spec/modules/amxBidAdapter_spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ describe('AmxBidAdapter', () => {
359359
bidId: sampleRequestId + '_2',
360360
params: {
361361
...sampleBidRequestBase.params,
362+
adUnitId: '',
362363
tagId: 'example',
363364
},
364365
},
@@ -404,12 +405,12 @@ describe('AmxBidAdapter', () => {
404405

405406
it('can build a video request', () => {
406407
const { data } = spec.buildRequests(
407-
[sampleBidRequestVideo],
408+
[{...sampleBidRequestVideo, params: { ...sampleBidRequestVideo.params, adUnitId: 'custom-auid' }}],
408409
sampleBidderRequest
409410
);
410411
expect(Object.keys(data.m).length).to.equal(1);
411412
expect(data.m[sampleRequestId + '_video']).to.deep.equal({
412-
au: 'div-gpt-ad-example',
413+
au: 'custom-auid',
413414
ms: [[[300, 150]], [], [[360, 250]]],
414415
av: true,
415416
aw: 360,

0 commit comments

Comments
 (0)