Skip to content

Commit 6827cc0

Browse files
Bill Newmanvladis-teqblazeAiholkinMykhailo Yaremchuk
authored andcommitted
Colossus Bid Adapter: update buildRequests - add tid to request data (prebid#9056)
* add video&native traffic colossus ssp * Native obj validation * Native obj validation #2 * Added size field in requests * fixed test * fix merge conflicts * move to 3.0 * move to 3.0 * fix IE11 new URL issue * fix IE11 new URL issue * fix IE11 new URL issue * https for 3.0 * add https test * add ccp and schain features * fix test * sync with upstream, fix conflicts * Update colossussspBidAdapter.js remove commented code * Update colossussspBidAdapter.js lint fix * identity extensions * identity extensions * fix * fix * fix * fix * fix * add tests for user ids * fix * fix * fix * fix * fix * fix * fix * add gdpr support * add gdpr support * id5id support * Update colossussspBidAdapter.js add bidfloor parameter * Update colossussspBidAdapter.js check bidfloor * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter_spec.js * use floor module * Revert "use floor module" This reverts commit f0c5c24. * use floor module * update to 5v * fix * add uid2 and bidFloor support * fix * add pbadslot support * fix conflicts * add onBidWon * refactor * add test for onBidWon() * fix * add group_id * Trigger circleci * fix * update user sync * fix window.location * fix test * updates * fix conflict * fix * updates * remove traffic param * add transactionId to request data for colossusssp adapter * Send tid in placements array Co-authored-by: Vladislav Isaiko <[email protected]> Co-authored-by: Aiholkin <[email protected]> Co-authored-by: Mykhailo Yaremchuk <[email protected]>
1 parent 2c78bad commit 6827cc0

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

modules/colossussspBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export const spec = {
9797
secure: location.protocol === 'https:' ? 1 : 0,
9898
host: location.host,
9999
page: location.pathname,
100-
placements: placements,
100+
placements: placements
101101
};
102102

103103
if (bidderRequest) {
@@ -117,6 +117,7 @@ export const spec = {
117117
placementId: bid.params.placement_id,
118118
groupId: bid.params.group_id,
119119
bidId: bid.bidId,
120+
tid: bid.transactionId,
120121
eids: [],
121122
floor: {}
122123
};

test/spec/modules/colossussspBidAdapter_spec.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe('ColossussspAdapter', function () {
101101
let placements = data['placements'];
102102
for (let i = 0; i < placements.length; i++) {
103103
let placement = placements[i];
104-
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
104+
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid', 'tid');
105105
expect(placement.schain).to.be.an('object')
106106
expect(placement.placementId).to.be.a('number');
107107
expect(placement.groupId).to.be.a('number');
@@ -110,6 +110,7 @@ describe('ColossussspAdapter', function () {
110110
expect(placement.sizes).to.be.an('array');
111111
expect(placement.floor).to.be.an('object');
112112
expect(placement.gpid).to.be.an('string');
113+
expect(placement.tid).to.be.an('string');
113114
}
114115
});
115116

@@ -143,7 +144,7 @@ describe('ColossussspAdapter', function () {
143144
let placement = placements[i];
144145
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'schain', 'floor', 'gpid', 'sizes',
145146
'playerSize', 'minduration', 'maxduration', 'mimes', 'protocols', 'startdelay', 'placement', 'skip', 'skipafter',
146-
'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity'
147+
'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity', 'tid'
147148
);
148149
expect(placement.schain).to.be.an('object')
149150
expect(placement.placementId).to.be.a('number');
@@ -155,6 +156,7 @@ describe('ColossussspAdapter', function () {
155156
expect(placement.playerSize).to.be.an('array');
156157
expect(placement.minduration).to.be.an('number');
157158
expect(placement.maxduration).to.be.an('number');
159+
expect(placement.tid).to.be.an('string');
158160
}
159161
});
160162

0 commit comments

Comments
 (0)