Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with rust 1.77.0 #4137

Closed
2 tasks done
MikaelUrankar opened this issue Mar 19, 2024 · 3 comments · Fixed by #4139
Closed
2 tasks done

Fails to build with rust 1.77.0 #4137

MikaelUrankar opened this issue Mar 19, 2024 · 3 comments · Fixed by #4139
Assignees
Labels
A-dependencies Area: Dependencies C-bug Category: Bug

Comments

@MikaelUrankar
Copy link

Bug Description

I have the following error with rust 1.77.0:

  --- stderr                                                                                  
  thread 'main' panicked at crates/router_env/src/cargo_workspace.rs:57:5:
  Unknown workspace members package ID format. Please run `cargo metadata --format-version=1 | jq '.workspace_members'` and update this build script to match the updated package ID format.

The format of ids in 'cargo metadata' has changed with cargo 1.77, it's documented here: rust-lang/cargo#13528

Expected Behavior

It should build.

Actual Behavior

It fails to build.

Steps To Reproduce

exec cargo build with rust 1.77.0

Context For The Bug

  --- stderr                                                                                  
  thread 'main' panicked at crates/router_env/src/cargo_workspace.rs:57:5:
  Unknown workspace members package ID format. Please run `cargo metadata --format-version=1 | jq '.workspace_members'` and update this build script to match the updated package ID format.

Environment

If not (or if building/running locally), please provide the following details:

  1. Operating System: FreeBSD
  2. Rust version (output of rustc --version): rustc 1.77.0 (aedd173a2 2024-03-17) (built from a source tarball) binary: rustc commit-hash: aedd173a2c086e558c2b66d3743b344f977621a7 commit-date: 2024-03-17 host: x86_64-unknown-freebsd release: 1.77.0 LLVM version: 17.0.6
  3. App version (output of cargo r --features vergen -- --version): ``

Have you spent some time checking if this bug has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@MikaelUrankar MikaelUrankar added C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet labels Mar 19, 2024
@SanchithHegde
Copy link
Member

Hey @MikaelUrankar, thanks for reporting this. I suspected that the package ID format being stabilized would affect us when I read the Rust 1.77.0 pre-release testing blog post and landed on rust-lang/cargo#12914, but hadn't tried building on Rust 1.77. Appreciate you taking the time to build and report it, I will have this fixed.

Until then, could you build with the latest stable Rust toolchain (1.76 as of now)?

You can try that with a command like so: cargo +1.76 build
And you can install the Rust 1.76 toolchain using rustup like so: rustup install 1.76

@SanchithHegde SanchithHegde added A-dependencies Area: Dependencies and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Mar 19, 2024
@SanchithHegde SanchithHegde self-assigned this Mar 19, 2024
@MikaelUrankar
Copy link
Author

hyperswitch builds fine with rust 1.76.0. I am preparing the update to rust 1.77.0 (I am the FreeBSD rust maintainer) and encounter this error.
Thanks.

@SanchithHegde
Copy link
Member

Thanks again for reporting, I've opened #4139 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies C-bug Category: Bug
Projects
None yet
3 participants