Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message on unauthorized login attempts. #119

Closed
lambdaTotoro opened this issue Oct 28, 2020 · 2 comments
Closed

Better error message on unauthorized login attempts. #119

lambdaTotoro opened this issue Oct 28, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@lambdaTotoro
Copy link
Collaborator

Currently, if you create a new account through normal sign-up, and immediately try to log in, this will fail due to the account not being authorized yet, but the error message will read "Invalid username or password". That gives users an incorrect idea about why they are unable to login and may lead to frustration.

It would be better if failed login attempts would distinguish between "correct credentials but no authorization" and "wrong credentials" and displayed an appropriate error message.

@lambdaTotoro lambdaTotoro added the enhancement New feature or request label Oct 28, 2020
@lambdaTotoro
Copy link
Collaborator Author

lambdaTotoro commented Oct 29, 2020

Some notes for future me:

  • The error message comes from the upstream JupyterHub Login Manager, that will probably have to be overridden.
  • It might be worth another think if this exposes (the correctness of) login credentials, maybe check for authorization before checking correctness.

@lambdaTotoro
Copy link
Collaborator Author

It might be worth another think if this exposes (the correctness of) login credentials, maybe check for authorization before checking correctness.

I've decided that this is a negligible concern, since this only has any effect if a would-be attacker knows or correctly guesses the user's password. Normally, that would just lead to login, which is equally unfortunate. If this is too risky for anyone, they can default to the n-attempts-to-ban mechanic.

@lambdaTotoro lambdaTotoro added this to the Version 1.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant