Skip to content

Commit 28faa9b

Browse files
committed
fix version comp
1 parent 18b0921 commit 28faa9b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pythreejs/_base/Three.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,13 @@
33

44
try:
55
from importlib.metadata import version
6+
from packaging.version import parse, Version
7+
def version_gte_than(pkg, minimum_supported):
8+
return parse(version(pkg)) >= Version(minimum_supported)
69
except ImportError:
7-
def version(pkg):
10+
def version_gte_than(pkg, minimum_supported):
811
import pkg_resources
9-
return pkg_resources.get_distribution(pkg).version
12+
return pkg_resources.get_distribution(pkg).parsed_version >= pkg_resources.parse_version(minimum_supported)
1013

1114
from .._package import npm_pkg_name
1215
from .._version import EXTENSION_SPEC_VERSION
@@ -46,7 +49,7 @@ def _on_ret_val(self, method_name, ret_val):
4649
"""Message callback used internally for logging exec returns"""
4750
self.log.info('%s() -> %s' % (method_name, ret_val))
4851

49-
if version("ipywidget") >= (8, 0, 0):
52+
if version_gte_than("ipywidgets", "8.0.0"):
5053
def _repr_mimebundle_(self, **kwargs):
5154
if self._previewable:
5255
from .renderable import Preview

0 commit comments

Comments
 (0)