Skip to content

Commit 828cdb3

Browse files
committed
Prune duplicate elements in resources
Prior to this commit a list with potential duplicates is generated and verified when loading the `junit-platform.properties` file. Addresses #2207
1 parent edcbd81 commit 828cdb3

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherConfigurationParameters.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@
1414
import java.net.URL;
1515
import java.net.URLConnection;
1616
import java.util.Collections;
17-
import java.util.List;
17+
import java.util.HashSet;
1818
import java.util.Map;
1919
import java.util.Optional;
2020
import java.util.Properties;
21+
import java.util.Set;
2122

2223
import org.junit.platform.commons.logging.Logger;
2324
import org.junit.platform.commons.logging.LoggerFactory;
@@ -52,7 +53,7 @@ private static Properties fromClasspathResource(String configFileName) {
5253

5354
try {
5455
ClassLoader classLoader = ClassLoaderUtils.getDefaultClassLoader();
55-
List<URL> resources = Collections.list(classLoader.getResources(configFileName));
56+
Set<URL> resources = new HashSet<>(Collections.list(classLoader.getResources(configFileName)));
5657

5758
if (!resources.isEmpty()) {
5859
if (resources.size() > 1) {
@@ -61,7 +62,7 @@ private static Properties fromClasspathResource(String configFileName) {
6162
resources.size(), configFileName));
6263
}
6364

64-
URL configFileUrl = resources.get(0);
65+
URL configFileUrl = resources.iterator().next(); // same as List#get(0)
6566
logger.info(() -> String.format(
6667
"Loading JUnit Platform configuration parameters from classpath resource [%s].", configFileUrl));
6768
URLConnection urlConnection = configFileUrl.openConnection();

0 commit comments

Comments
 (0)