minor changes based on code review

Author: li-ruihao

application/__init__.py

@@ -32,7 +32,6 @@
         config = yaml.safe_load(config_file.read())
 
     config['handlers']['timedRotatingFile']['filename'] = paths.LOG_FILE_PATH
-    paths.makedir_if_not_exists(paths.LOGS_DIR_PATH)
     logging.config.dictConfig(config)
 except Exception:
     # Fallback to a basic configuration

application/paths.py

@@ -40,4 +40,5 @@ def makedir_if_not_exists(path):
 PRIVATE_KEY_PATH = os.path.join(PROFILE_PATH, "private_keys")
 makedir_if_not_exists(PRIVATE_KEY_PATH)
 LOGS_DIR_PATH = os.path.join(PROFILE_PATH, 'logs')
+makedir_if_not_exists(LOGS_DIR_PATH)
 LOG_FILE_PATH = os.path.join(LOGS_DIR_PATH, 'ictrl_log.log')

log_config.yaml

@@ -18,8 +18,9 @@ handlers:
         formatter: default
         when: H
         interval: 3
+        # See discussion on backupCount decision: https://github.com/junhaoliao/iCtrl/pull/46/files/0c148d0e47dc9ae42014f10a4a04e0aaffca7cbd#r1921487166
         backupCount: 112
-        # filename: dynamically assigned upon the initialization of the program
+        # filename: To be dynamically assigned upon application initialization.
 
 root:
     level: DEBUG