Update Python API generator for Python 3

Change PythonAPIGenerator to use the six library, for compatibility with
Python 2 and 3. Also, tweak it to be more compliant with PEP8.

For/from zaproxy/zap-api-python#4 - Fix for Python 3

Author: thc202

src/org/zaproxy/zap/extension/api/PythonAPIGenerator.java

@@ -92,6 +92,7 @@ public void generatePythonFiles(List<ApiImplementor> implementors) throws IOExce
 	private void generatePythonElement(ApiElement element, String component, 
 			String type, Writer out) throws IOException {
 
+		out.write("\n\n");
 		boolean hasParams = (element.getMandatoryParamNames() != null && 
 								element.getMandatoryParamNames().size() > 0) ||
 							(element.getOptionalParamNames() != null &&
@@ -163,15 +164,15 @@ private void generatePythonElement(ApiElement element, String component,
 					} else {
 						reqParams.append(", ");
 					}
-					reqParams.append("'" + param + "' : " + param.toLowerCase());
+					reqParams.append("'" + param + "': " + param.toLowerCase());
 				}
 			}
 			if (type.equals(ACTION_ENDPOINT) || type.equals(OTHER_ENDPOINT)) {
 				// Always add the API key - we've no way of knowing if it will be required or not
 				if (!first) {
 					reqParams.append(", ");
 				}
-				reqParams.append("'").append(API.API_KEY_PARAM).append("' : ").append(API.API_KEY_PARAM);
+				reqParams.append("'").append(API.API_KEY_PARAM).append("': ").append(API.API_KEY_PARAM);
 			}
 			reqParams.append("}");
 
@@ -191,7 +192,7 @@ private void generatePythonElement(ApiElement element, String component,
 		if (type.equals(OTHER_ENDPOINT)) {
 			out.write("        return ("); 
 		} else {
-			out.write("        return next("); 
+			out.write("        return six.next(six.itervalues("); 
 		}
 		out.write("self.zap." + method + "(self.zap." + baseUrl + " + '" + 
 				component + "/" + type + "/" + element.getName() + "/'");
@@ -202,16 +203,15 @@ private void generatePythonElement(ApiElement element, String component,
 			out.write(reqParams.toString());
 			out.write(")");
 			if (!type.equals(OTHER_ENDPOINT)) {
-				out.write(".itervalues())");
+				out.write("))");
 			} else {
 				out.write(")");
 			}
 		} else if (!type.equals(OTHER_ENDPOINT)) {
-			out.write(").itervalues())");
+			out.write(")))");
 		} else {
 			out.write(")");
 		}
-		out.write("\n\n");
 
 	}
 
@@ -221,10 +221,10 @@ protected void generateAPIFiles(ApiImplementor imp) throws IOException {
 		System.out.println("Generating " + file.toAbsolutePath());
 		try (BufferedWriter out = Files.newBufferedWriter(file, StandardCharsets.UTF_8)) {
 			out.write(HEADER);
+			out.write("import six\n\n\n");
 			out.write("class " + safeName(imp.getPrefix()) + "(object):\n\n");
 			out.write("    def __init__(self, zap):\n");
-			out.write("        self.zap = zap\n");
-			out.write("\n");
+			out.write("        self.zap = zap");
 
 			for (ApiElement view : imp.getApiViews()) {
 				this.generatePythonElement(view, imp.getPrefix(), VIEW_ENDPOINT, out);