Skip to content

Commit 438a9bc

Browse files
nlfdougwilson
authored andcommitted
Revert "Lazy-load modules from main entry point"
closes #60
1 parent 6e155dd commit 438a9bc

File tree

2 files changed

+9
-46
lines changed

2 files changed

+9
-46
lines changed

HISTORY.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
unreleased
2+
==========
3+
4+
* Revert "Lazy-load modules from main entry point"
5+
16
0.6.2 / 2019-04-29
27
==================
38

index.js

+4-46
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@
88

99
'use strict';
1010

11-
/**
12-
* Cached loaded submodules.
13-
* @private
14-
*/
15-
16-
var modules = Object.create(null);
11+
var preferredCharsets = require('./lib/charset')
12+
var preferredEncodings = require('./lib/encoding')
13+
var preferredLanguages = require('./lib/language')
14+
var preferredMediaTypes = require('./lib/mediaType')
1715

1816
/**
1917
* Module exports.
@@ -43,7 +41,6 @@ Negotiator.prototype.charset = function charset(available) {
4341
};
4442

4543
Negotiator.prototype.charsets = function charsets(available) {
46-
var preferredCharsets = loadModule('charset').preferredCharsets;
4744
return preferredCharsets(this.request.headers['accept-charset'], available);
4845
};
4946

@@ -53,7 +50,6 @@ Negotiator.prototype.encoding = function encoding(available) {
5350
};
5451

5552
Negotiator.prototype.encodings = function encodings(available) {
56-
var preferredEncodings = loadModule('encoding').preferredEncodings;
5753
return preferredEncodings(this.request.headers['accept-encoding'], available);
5854
};
5955

@@ -63,7 +59,6 @@ Negotiator.prototype.language = function language(available) {
6359
};
6460

6561
Negotiator.prototype.languages = function languages(available) {
66-
var preferredLanguages = loadModule('language').preferredLanguages;
6762
return preferredLanguages(this.request.headers['accept-language'], available);
6863
};
6964

@@ -73,7 +68,6 @@ Negotiator.prototype.mediaType = function mediaType(available) {
7368
};
7469

7570
Negotiator.prototype.mediaTypes = function mediaTypes(available) {
76-
var preferredMediaTypes = loadModule('mediaType').preferredMediaTypes;
7771
return preferredMediaTypes(this.request.headers.accept, available);
7872
};
7973

@@ -86,39 +80,3 @@ Negotiator.prototype.preferredLanguage = Negotiator.prototype.language;
8680
Negotiator.prototype.preferredLanguages = Negotiator.prototype.languages;
8781
Negotiator.prototype.preferredMediaType = Negotiator.prototype.mediaType;
8882
Negotiator.prototype.preferredMediaTypes = Negotiator.prototype.mediaTypes;
89-
90-
/**
91-
* Load the given module.
92-
* @private
93-
*/
94-
95-
function loadModule(moduleName) {
96-
var module = modules[moduleName];
97-
98-
if (module !== undefined) {
99-
return module;
100-
}
101-
102-
// This uses a switch for static require analysis
103-
switch (moduleName) {
104-
case 'charset':
105-
module = require('./lib/charset');
106-
break;
107-
case 'encoding':
108-
module = require('./lib/encoding');
109-
break;
110-
case 'language':
111-
module = require('./lib/language');
112-
break;
113-
case 'mediaType':
114-
module = require('./lib/mediaType');
115-
break;
116-
default:
117-
throw new Error('Cannot find module \'' + moduleName + '\'');
118-
}
119-
120-
// Store to prevent invoking require()
121-
modules[moduleName] = module;
122-
123-
return module;
124-
}

0 commit comments

Comments
 (0)