Polyfill: Make buildMonthCode less opaque

ptomato · ptomato · commit d87ed96506de · 2025-03-17T13:09:45.000-07:00
Split out some things into local variables for readability.

UPSTREAM_COMMIT=8a790146e505254fbbeb93b1d5647aa562fff63f
diff --git a/lib/calendar.ts b/lib/calendar.ts
@@ -417,8 +417,10 @@ function monthCodeNumberPart(monthCode: string) {
   return month;
 }
 
-function buildMonthCode(month: number | string, leap = false) {
-  return `M${Call(StringPrototypePadStart, `${month}`, [2, '0'])}${leap ? 'L' : ''}`;
+function buildMonthCode(month: number, leap = false) {
+  const digitPart = Call(StringPrototypePadStart, `${month}`, [2, '0']);
+  const leapMarker = leap ? 'L' : '';
+  return `M${digitPart}${leapMarker}`;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -417,8 +417,10 @@ function monthCodeNumberPart(monthCode: string) {`
`417`	`417`	`return month;`
`418`	`418`	`}`
`419`	`419`
`420`		`-function buildMonthCode(month: number \| string, leap = false) {`
`421`		- return `M${Call(StringPrototypePadStart, `${month}`, [2, '0'])}${leap ? 'L' : ''}`;
	`420`	`+function buildMonthCode(month: number, leap = false) {`
	`421`	+ const digitPart = Call(StringPrototypePadStart, `${month}`, [2, '0']);
	`422`	`+ const leapMarker = leap ? 'L' : '';`
	`423`	+ return `M${digitPart}${leapMarker}`;
`422`	`424`	`}`
`423`	`425`
`424`	`426`	`/**`