Skip to content

Commit efac0b2

Browse files
authored
feat(events): default events prop to an empty array (#2161)
Changes to default props to no longer make events required, defaulting to an empty array #1708
1 parent 864f851 commit efac0b2

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

.husky/pre-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#!/bin/sh
22
. "$(dirname "$0")/_/husky.sh"
33

4-
npx lint-staged
4+
NODE_ENV=development npx lint-staged

src/Calendar.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -845,6 +845,8 @@ class Calendar extends React.Component {
845845
}
846846

847847
static defaultProps = {
848+
events: [],
849+
backgroundEvents: [],
848850
elementProps: {},
849851
popup: false,
850852
toolbar: true,
@@ -981,7 +983,7 @@ class Calendar extends React.Component {
981983
view,
982984
toolbar,
983985
events,
984-
backgroundEvents = [],
986+
backgroundEvents,
985987
style,
986988
className,
987989
elementProps,

stories/props/API.stories.mdx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ Callback fired when the `view` value changes. When included it is used to 'contr
150150

151151
### events
152152

153-
- type: `arrayOf(Event)` **required**
153+
- type: `arrayOf(Event)`
154+
- default: `[]`
154155
- <LinkTo kind="props" story="events">
155156
Example
156157
</LinkTo>

stories/props/events.mdx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { Canvas, Story } from '@storybook/addon-docs'
22

33
# events
44

5-
- type: `arrayOf(Event)` **required**
5+
- type: `arrayOf(Event)`
6+
- default: `[]`
67

78
An array of event objects to display on the calendar. Events objects
89
can be any shape, as long as the Calendar knows how to retrieve the

stories/props/events.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const Template = (args) => (
3131
)
3232

3333
export const Events = Template.bind({})
34-
Events.storyName = 'events *'
34+
Events.storyName = 'events'
3535
Events.args = {
3636
defaultDate: new Date(2015, 3, 13),
3737
events: demoEvents,

0 commit comments

Comments
 (0)