fix: rounding behavior in Luxon localizer (#2362)

pdady · web-flow · commit 409cff1d74a3 · 2023-02-09T11:13:25.000-05:00
Round down the date difference returned in the diff function of the luxon localizer to the nearest whole number, aligning the behavior with other localizers. #2361
diff --git a/src/localizers/luxon.js b/src/localizers/luxon.js
@@ -239,7 +239,7 @@ export default function (DateTime, { firstDayOfWeek = 7 } = {}) {
     // don't use 'defineComparators' here, as we don't want to mutate the values
     const dtA = DateTime.fromJSDate(a)
     const dtB = DateTime.fromJSDate(b)
-    return Math.round(
+    return Math.floor(
       dtB.diff(dtA, datePart, { conversionAccuracy: 'longterm' }).toObject()[
         datePart
       ]

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ export default function (DateTime, { firstDayOfWeek = 7 } = {}) {`
`239`	`239`	`// don't use 'defineComparators' here, as we don't want to mutate the values`
`240`	`240`	`const dtA = DateTime.fromJSDate(a)`
`241`	`241`	`const dtB = DateTime.fromJSDate(b)`
`242`		`- return Math.round(`
	`242`	`+ return Math.floor(`
`243`	`243`	`dtB.diff(dtA, datePart, { conversionAccuracy: 'longterm' }).toObject()[`
`244`	`244`	`datePart`
`245`	`245`	`]`