Skip to content

feat(api): only notify people in post on new comment #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

johanbook
Copy link
Owner

Closes #671

@johanbook johanbook marked this pull request as ready for review December 16, 2023 06:18
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f413328) 43.29% compared to head (28f76ea) 49.40%.

Files Patch % Lines
...rganization-on-posted-blog-post-comment.handler.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   43.29%   49.40%   +6.11%     
==========================================
  Files         289      220      -69     
  Lines        3049     2524     -525     
  Branches      179      151      -28     
==========================================
- Hits         1320     1247      -73     
+ Misses       1669     1238     -431     
+ Partials       60       39      -21     
Flag Coverage Δ
api 49.40% <0.00%> (-0.06%) ⬇️
auth-api ?
homepage ?
tracking ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanbook johanbook merged commit c7c8731 into main Dec 16, 2023
@johanbook johanbook deleted the blog-comment-notification branch December 16, 2023 06:30
This was referenced Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Only show comment notifications to people on post
1 participant