fix(api): handle organzation and profile deletion

Author: Johan Book

services/api/src/core/organizations/infrastructure/entities/active-organization.entity.ts

@@ -7,15 +7,15 @@ import { Organization } from "./organization.entity";
 
 @Entity()
 export class ActiveOrganization extends BaseEntity {
+  @ManyToOne(() => Organization, { onDelete: "SET NULL" })
+  organization!: Organization;
+
   @Column()
   organizationId!: number;
 
-  @ManyToOne(() => Organization)
-  organization!: Organization;
+  @OneToOne(() => Profile, { onDelete: "CASCADE" })
+  profile!: Profile;
 
   @Column()
   profileId!: number;
-
-  @OneToOne(() => Profile)
-  profile!: Profile;
 }

services/api/src/core/organizations/infrastructure/entities/organization-membership.entity.ts

@@ -21,18 +21,22 @@ export class OrganizationMembership {
   @CreateDateColumn()
   created!: Date;
 
+  @ManyToOne(() => Organization, (organization) => organization.memberships, {
+    onDelete: "CASCADE",
+  })
+  organization!: Organization;
+
   @Column()
   organizationId!: number;
 
-  @ManyToOne(() => Organization, (organization) => organization.memberships)
-  organization!: Organization;
+  @ManyToOne(() => Profile, (profile) => profile.organizationMemberships, {
+    onDelete: "CASCADE",
+  })
+  profile!: Profile;
 
   @Column()
   profileId!: number;
 
-  @ManyToOne(() => Profile, (profile) => profile.organizationMemberships)
-  profile!: Profile;
-
   @Column({
     type: "enum",
     enum: OrganizationRole,

services/api/src/core/organizations/infrastructure/migrations/1720639767923-AddDeleteCascadeHandlers.ts

@@ -0,0 +1,24 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class AddDeleteCascadeHandlers1720639767923 implements MigrationInterface {
+    name = 'AddDeleteCascadeHandlers1720639767923'
+
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "organization_membership" DROP CONSTRAINT "FK_ee8dc62205b4c3acb1483da4142"`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" DROP CONSTRAINT "FK_827c4eb64b3510234ee23866f81"`);
+        await queryRunner.query(`ALTER TABLE "active_organization" DROP CONSTRAINT "FK_60b7353926f26cb16ccc4235408"`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" ADD CONSTRAINT "FK_ee8dc62205b4c3acb1483da4142" FOREIGN KEY ("organizationId") REFERENCES "organization"("id") ON DELETE CASCADE ON UPDATE NO ACTION`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" ADD CONSTRAINT "FK_827c4eb64b3510234ee23866f81" FOREIGN KEY ("profileId") REFERENCES "profile"("id") ON DELETE CASCADE ON UPDATE NO ACTION`);
+        await queryRunner.query(`ALTER TABLE "active_organization" ADD CONSTRAINT "FK_60b7353926f26cb16ccc4235408" FOREIGN KEY ("organizationId") REFERENCES "organization"("id") ON DELETE SET NULL ON UPDATE NO ACTION`);
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "active_organization" DROP CONSTRAINT "FK_60b7353926f26cb16ccc4235408"`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" DROP CONSTRAINT "FK_827c4eb64b3510234ee23866f81"`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" DROP CONSTRAINT "FK_ee8dc62205b4c3acb1483da4142"`);
+        await queryRunner.query(`ALTER TABLE "active_organization" ADD CONSTRAINT "FK_60b7353926f26cb16ccc4235408" FOREIGN KEY ("organizationId") REFERENCES "organization"("id") ON DELETE NO ACTION ON UPDATE NO ACTION`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" ADD CONSTRAINT "FK_827c4eb64b3510234ee23866f81" FOREIGN KEY ("profileId") REFERENCES "profile"("id") ON DELETE NO ACTION ON UPDATE NO ACTION`);
+        await queryRunner.query(`ALTER TABLE "organization_membership" ADD CONSTRAINT "FK_ee8dc62205b4c3acb1483da4142" FOREIGN KEY ("organizationId") REFERENCES "organization"("id") ON DELETE NO ACTION ON UPDATE NO ACTION`);
+    }
+
+}

services/api/src/core/profiles/infrastructure/entities/profile-photo.entity.ts

@@ -6,9 +6,11 @@ import { Profile } from "./profile.entity";
 
 @Entity()
 export class ProfilePhoto extends BasePhoto {
+  @OneToOne(() => Profile, (profile) => profile.profilePhoto, {
+    onDelete: "CASCADE",
+  })
+  profile!: Profile;
+
   @Column()
   profileId!: number;
-
-  @OneToOne(() => Profile, (profile) => profile.profilePhoto)
-  profile!: Profile;
 }

services/api/src/core/profiles/infrastructure/migrations/1720640142267-AddProfileDeleteCascadeHandlers.ts

@@ -0,0 +1,16 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class AddProfileDeleteCascadeHandlers1720640142267 implements MigrationInterface {
+    name = 'AddProfileDeleteCascadeHandlers1720640142267'
+
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "profile" ADD CONSTRAINT "UQ_e93f4cc04459521af4d5da5a2cc" UNIQUE ("profilePhotoId")`);
+        await queryRunner.query(`ALTER TABLE "profile" ADD CONSTRAINT "FK_e93f4cc04459521af4d5da5a2cc" FOREIGN KEY ("profilePhotoId") REFERENCES "profile_photo"("id") ON DELETE NO ACTION ON UPDATE NO ACTION`);
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "profile" DROP CONSTRAINT "FK_e93f4cc04459521af4d5da5a2cc"`);
+        await queryRunner.query(`ALTER TABLE "profile" DROP CONSTRAINT "UQ_e93f4cc04459521af4d5da5a2cc"`);
+    }
+
+}