Add mac,windows to CI

Author: tamird

.github/workflows/ci.yml

@@ -10,7 +10,15 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+        - macos-latest
+        - ubuntu-latest
+        - windows-latest
+
+    runs-on: ${{ matrix.os }}
 
     steps:
       - uses: actions/checkout@v4
@@ -20,6 +28,7 @@ jobs:
         with:
           tool: cargo-hack,taplo-cli
       - run: taplo fmt --check --diff
+        if: ${{ matrix.os != 'windows-latest' }} # https://github.com/tamasfe/taplo/issues/766
       - run: cargo fmt --all -- --check
       - run: cargo hack clippy --all-targets --feature-powerset --workspace -- --deny warnings
       - run: cargo hack test --all-targets --feature-powerset --workspace

src/main.rs

@@ -30,8 +30,6 @@ use std::ffi::OsString;
 use std::fmt::Write as _;
 use std::io::IsTerminal as _;
 use std::io::Write as _;
-#[cfg(unix)]
-use std::os::unix::fs::MetadataExt as _;
 use std::path::{Path, PathBuf};
 
 use anyhow::{Context as _, Error};
@@ -691,6 +689,19 @@ fn cmd_status(
   Ok(status)
 }
 
+#[cfg(unix)]
+fn is_same_device(left: &std::fs::Metadata, right: &std::fs::Metadata) -> bool {
+  use std::os::unix::fs::MetadataExt as _;
+  left.dev() == right.dev()
+}
+
+#[cfg(windows)]
+fn is_same_device(left: &std::fs::Metadata, right: &std::fs::Metadata) -> bool {
+  // TODO(https://github.com/rust-lang/rust/issues/63010): Use std::os::windows::fs::MetadataExt::volume_serial_number.
+  let _ = (left, right);
+  false
+}
+
 fn cmd_import(config: &Config, pool: &mut Pool, target_path: Option<PathBuf>, copy: bool) -> Result<i32, Error> {
   let target_path = target_path.unwrap_or(PathBuf::from("."));
   let target_metadata = std::fs::metadata(&target_path)?;
@@ -717,7 +728,7 @@ fn cmd_import(config: &Config, pool: &mut Pool, target_path: Option<PathBuf>, co
     std::fs::create_dir_all(&depot.path).context("failed to create depot directory")?;
     let depot_metadata = std::fs::metadata(&depot.path)?;
 
-    if !copy && depot_metadata.dev() != target_metadata.dev() {
+    if !copy && !is_same_device(&depot_metadata, &target_metadata) {
       bail!(
         "Depot ({:?}) and target ({:?}) appear to be on different filesystems.\n       \
              Either move the depot to the same filesystem, or use --copy to copy instead.",

src/tree.rs

@@ -19,8 +19,6 @@ use std::fmt;
 use std::io::Write;
 use std::iter::FromIterator as _;
 use std::ops::Deref as _;
-#[cfg(unix)]
-use std::os::unix::fs::PermissionsExt as _;
 use std::path::{Path, PathBuf};
 
 use anyhow::{Context as _, Error};
@@ -1044,6 +1042,8 @@ impl Tree {
     // that prohibits it.
     #[cfg(unix)]
     {
+      use std::os::unix::fs::PermissionsExt as _;
+
       let mut permissions = file.metadata()?.permissions();
       permissions.set_mode(0o700);
       file.set_permissions(permissions)?;