Skip to content

4.3 breaks phantomJS tests #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rlucha opened this issue Jul 7, 2015 · 2 comments
Closed

4.3 breaks phantomJS tests #190

rlucha opened this issue Jul 7, 2015 · 2 comments
Assignees
@jmdobry
Labels
3 - Done bug

Comments

@rlucha
Copy link

rlucha commented Jul 7, 2015

Updating from 4.2 to 4.3 breaks our karma suite, the following errors appear:

PhantomJS 1.9.8 (Linux 0.0.0) ec-autocomplete-controller encountered a declaration exception FAILED
ReferenceError: Can't find variable: Promise
Error: [$injector:modulerr] Failed to instantiate module undefined due to:
Error: [ng:areq] Argument 'module' is not a function, got undefined

We have switched to ~4.2.0 for now until we can investigate further.
@jmdobry jmdobry closed this as completed in ac58584 Jul 7, 2015
@jmdobry jmdobry self-assigned this Jul 7, 2015
@rlucha
Copy link
Author

rlucha commented Jul 7, 2015

Fast! thank you

@jmdobry
Copy link
Owner

jmdobry commented Jul 7, 2015

No problem, that was my bad, not anticipating others would have PhantomJS tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
3 - Done bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmdobry @rlucha