fix(whisper): Keep sockets in the call object.

Having them in a pool risks leaking it and can cause not having transcription for a particular room.

Author: damencho

src/main/java/org/jitsi/jigasi/CallContext.java

@@ -17,6 +17,7 @@
  */
 package org.jitsi.jigasi;
 
+import net.java.sip.communicator.util.*;
 import org.apache.commons.lang3.StringUtils;
 import com.google.common.base.*;
 
@@ -34,6 +35,7 @@
  * @author Damian Minkov
  */
 public class CallContext
+    extends DataObject
 {
     private final static Logger logger = Logger.getLogger(CallContext.class);
 

src/main/java/org/jitsi/jigasi/transcription/WhisperConnectionPool.java

@@ -18,28 +18,31 @@
 package org.jitsi.jigasi.transcription;
 
 import org.jitsi.impl.neomedia.device.*;
+import org.jitsi.jigasi.*;
 import org.jitsi.jigasi.stats.*;
 import org.jitsi.utils.logging.*;
 
 import java.nio.*;
 import java.util.function.*;
 
-
 /**
  * Implements a TranscriptionService which uses a custom built Whisper server
  * to perform live transcription.
  *
  * @author Razvan Purdel
  */
 public class WhisperTranscriptionService
-        extends AbstractTranscriptionService
+    extends AbstractTranscriptionService
 {
-
     /**
      * The logger for this class
      */
-    private final static Logger logger
-            = Logger.getLogger(WhisperTranscriptionService.class);
+    private final static Logger logger = Logger.getLogger(WhisperTranscriptionService.class);
+
+    /**
+     * The Key to use to put a websocket connection in the call context so we can share it for the room.
+     */
+    private final static String WHISPER_WS_CONNECTION_KEY = "whisper_ws_connection";
 
     @Override
     public AudioMixerMediaDevice getMediaDevice(ReceiveStreamBufferListener listener)
@@ -118,7 +121,7 @@ public boolean supportsStreamRecognition()
      * the lifecycle of websocket
      */
     public static class WhisperWebsocketStreamingSession
-            implements StreamingRecognitionSession
+        implements StreamingRecognitionSession
     {
 
         private final Participant participant;
@@ -133,20 +136,38 @@ public static class WhisperWebsocketStreamingSession
 
         private final String roomId;
 
-        private final WhisperConnectionPool connectionPool;
-
-
         WhisperWebsocketStreamingSession(Participant participant)
         {
             this.participant = participant;
             String[] debugName = this.participant.getDebugName().split("/");
             participantId = debugName[1];
             roomId = participant.getTranscriber().getRoomName();
-            connectionPool = WhisperConnectionPool.getInstance();
-            wsClient = connectionPool.getConnection(roomId);
+            wsClient = getConnection();
             wsClient.setTranscriptionTag(transcriptionTag);
         }
 
+        /**
+         * Gets a connection if it exists, creates one if it doesn't.
+         * @return The websocket.
+         */
+        public WhisperWebsocket getConnection()
+        {
+            CallContext ctx = this.participant.getCallContext();
+            WhisperWebsocket socket = (WhisperWebsocket)ctx.getData(WHISPER_WS_CONNECTION_KEY);
+
+            if (socket == null)
+            {
+                logger.info(ctx + " Creating a new websocket connection.");
+                socket = new WhisperWebsocket();
+
+                socket.connect();
+
+                ctx.setData(WHISPER_WS_CONNECTION_KEY, socket);
+            }
+
+            return socket;
+        }
+
         public void sendRequest(TranscriptionRequest request)
         {
             if (this.wsClient.ended())
@@ -174,8 +195,7 @@ public void addTranscriptionListener(TranscriptionListener listener)
 
         public void end()
         {
-            logger.info("Disconnecting " + this.participantId + " from Whisper transcription service.");
-            connectionPool.end(this.roomId, this.participantId);
+            wsClient.disconnectParticipant(this.participantId, allDisconnected -> {});
         }
 
         public boolean ended()

src/main/java/org/jitsi/jigasi/transcription/WhisperTranscriptionService.java

@@ -38,7 +38,7 @@
 
 /**
  * This holds the websocket that is used to send audio data to the Whisper.
- * This is one WhisperWebsocket per room (mapping is in <link>WhisperConnectionPool</link>).
+ * This is one WhisperWebsocket per room.
  * The jetty WebSocketClient process messages in a single thread.
  */
 @WebSocket