Skip to content

Commit e3f73f7

Browse files
committed
fixup! fixup! RHOAIENG-21668: chore(gha): implement the rhel building on pull_request_trigger workflow
1 parent 04f69b7 commit e3f73f7

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

rstudio/rhel9-python-3.11/Dockerfile.cpu

+7-4
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ USER 0
5252
#RUN sed -i 's/\(def in_container():\)/\1\n return False/g' /usr/lib64/python*/*-packages/rhsm/config.py
5353

5454
# If necessary, run the subscription manager command using the provided credentials. Only include --serverurl and --baseurl if they are provided
55-
RUN [ -d "${SECRET_DIR}" ] && \
56-
(SERVERURL=$(cat ${SECRET_DIR}/SERVERURL 2>/dev/null || echo ${SERVERURL_DEFAULT}) && \
55+
RUN if [ -d "${SECRET_DIR}" ]; then \
56+
SERVERURL=$(cat ${SECRET_DIR}/SERVERURL 2>/dev/null || echo ${SERVERURL_DEFAULT}) && \
5757
BASEURL=$(cat ${SECRET_DIR}/BASEURL 2>/dev/null || echo ${BASEURL_DEFAULT}) && \
5858
USERNAME=$(cat ${SECRET_DIR}/USERNAME) && \
5959
PASSWORD=$(cat ${SECRET_DIR}/PASSWORD) && \
@@ -63,7 +63,8 @@ RUN [ -d "${SECRET_DIR}" ] && \
6363
--username=$USERNAME \
6464
--password=$PASSWORD \
6565
--force \
66-
--auto-attach)
66+
--auto-attach; \
67+
fi
6768

6869
ENV R_VERSION=4.4.1
6970

@@ -170,7 +171,9 @@ COPY ${RSTUDIO_SOURCE_CODE}/utils utils/
170171
COPY ${RSTUDIO_SOURCE_CODE}/run-rstudio.sh ${RSTUDIO_SOURCE_CODE}/setup_rstudio.py ${RSTUDIO_SOURCE_CODE}/rsession.sh ${RSTUDIO_SOURCE_CODE}/run-nginx.sh ./
171172

172173
# Unregister the system
173-
RUN [ -d "${SECRET_DIR}" ] && (subscription-manager remove --all && subscription-manager unregister && subscription-manager clean)
174+
RUN if [ -d "${SECRET_DIR}" ]; then \
175+
subscription-manager remove --all && subscription-manager unregister && subscription-manager clean; \
176+
fi
174177

175178
USER 1001
176179

rstudio/rhel9-python-3.11/Dockerfile.cuda

+13-7
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ USER 0
4242
WORKDIR /opt/app-root/bin
4343

4444
# If necessary, run the subscription manager command using the provided credentials. Only include --serverurl and --baseurl if they are provided
45-
RUN [ -d "${SECRET_DIR}" ] && \
45+
RUN if [ -d "${SECRET_DIR}" ]; then \
4646
(SERVERURL=$(cat ${SECRET_DIR}/SERVERURL 2>/dev/null || echo ${SERVERURL_DEFAULT}) && \
4747
BASEURL=$(cat ${SECRET_DIR}/BASEURL 2>/dev/null || echo ${BASEURL_DEFAULT}) && \
4848
USERNAME=$(cat ${SECRET_DIR}/USERNAME) && \
@@ -53,7 +53,8 @@ RUN [ -d "${SECRET_DIR}" ] && \
5353
--username=$USERNAME \
5454
--password=$PASSWORD \
5555
--force \
56-
--auto-attach)
56+
--auto-attach; \
57+
fi
5758

5859
ENV NVARCH=x86_64
5960
ENV NVIDIA_REQUIRE_CUDA="cuda>=12.4 brand=tesla,driver>=470,driver<471 brand=unknown,driver>=470,driver<471 brand=nvidia,driver>=470,driver<471 brand=nvidiartx,driver>=470,driver<471 brand=geforce,driver>=470,driver<471 brand=geforcertx,driver>=470,driver<471 brand=quadro,driver>=470,driver<471 brand=quadrortx,driver>=470,driver<471 brand=titan,driver>=470,driver<471 brand=titanrtx,driver>=470,driver<471 brand=tesla,driver>=525,driver<526 brand=unknown,driver>=525,driver<526 brand=nvidia,driver>=525,driver<526 brand=nvidiartx,driver>=525,driver<526 brand=geforce,driver>=525,driver<526 brand=geforcertx,driver>=525,driver<526 brand=quadro,driver>=525,driver<526 brand=quadrortx,driver>=525,driver<526 brand=titan,driver>=525,driver<526 brand=titanrtx,driver>=525,driver<526 brand=tesla,driver>=535,driver<536 brand=unknown,driver>=535,driver<536 brand=nvidia,driver>=535,driver<536 brand=nvidiartx,driver>=535,driver<536 brand=geforce,driver>=535,driver<536 brand=geforcertx,driver>=535,driver<536 brand=quadro,driver>=535,driver<536 brand=quadrortx,driver>=535,driver<536 brand=titan,driver>=535,driver<536 brand=titanrtx,driver>=535,driver<536"
@@ -166,7 +167,9 @@ RUN yum -y install cuda-toolkit-12-4 && \
166167
yum -y clean all --enablerepo="*"
167168

168169
# Unregister the system
169-
RUN [ -d "${SECRET_DIR}" ] && (subscription-manager remove --all && subscription-manager unregister && subscription-manager clean)
170+
RUN if [ -d "${SECRET_DIR}" ]; then \
171+
subscription-manager remove --all && subscription-manager unregister && subscription-manager clean; \
172+
fi
170173

171174
# Restore notebook user workspace
172175
USER 1001
@@ -199,8 +202,8 @@ USER 0
199202
#RUN sed -i 's/\(def in_container():\)/\1\n return False/g' /usr/lib64/python*/*-packages/rhsm/config.py
200203

201204
# If necessary, run the subscription manager command using the provided credentials. Only include --serverurl and --baseurl if they are provided
202-
RUN [ -d "${SECRET_DIR}" ] && \
203-
(SERVERURL=$(cat ${SECRET_DIR}/SERVERURL 2>/dev/null || echo ${SERVERURL_DEFAULT}) && \
205+
RUN if [ -d "${SECRET_DIR}" ]; then \
206+
SERVERURL=$(cat ${SECRET_DIR}/SERVERURL 2>/dev/null || echo ${SERVERURL_DEFAULT}) && \
204207
BASEURL=$(cat ${SECRET_DIR}/BASEURL 2>/dev/null || echo ${BASEURL_DEFAULT}) && \
205208
USERNAME=$(cat ${SECRET_DIR}/USERNAME) && \
206209
PASSWORD=$(cat ${SECRET_DIR}/PASSWORD) && \
@@ -210,7 +213,8 @@ RUN [ -d "${SECRET_DIR}" ] && \
210213
--username=$USERNAME \
211214
--password=$PASSWORD \
212215
--force \
213-
--auto-attach)
216+
--auto-attach; \
217+
fi
214218

215219
ENV R_VERSION=4.4.1
216220

@@ -317,7 +321,9 @@ COPY ${RSTUDIO_SOURCE_CODE}/utils utils/
317321
COPY ${RSTUDIO_SOURCE_CODE}/run-rstudio.sh ${RSTUDIO_SOURCE_CODE}/setup_rstudio.py ${RSTUDIO_SOURCE_CODE}/rsession.sh ${RSTUDIO_SOURCE_CODE}/run-nginx.sh ./
318322

319323
# Unregister the system
320-
RUN [ -d "${SECRET_DIR}" ] && (subscription-manager remove --all && subscription-manager unregister && subscription-manager clean)
324+
RUN if [ -d "${SECRET_DIR}" ]; then
325+
subscription-manager remove --all && subscription-manager unregister && subscription-manager clean; \
326+
fi
321327

322328
USER 1001
323329

0 commit comments

Comments
 (0)