Skip to content

Commit 6462424

Browse files
committed
RHOAIENG-19043: chore(tests): fix 2024b ci builds after repo restructuring
1 parent cea9eb4 commit 6462424

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ endef
9494
# BUILD_DEPENDENT_IMAGES: only build images that were explicitly given as a goal on command line
9595
# PUSH_IMAGES: allows skipping podman push
9696
define image
97-
$(info #*# Image build directory: <$(2)> #(MACHINE-PARSED LINE)#*#...)
97+
$(info #*# Image build directory: <$(RELEASE)/$(2)> #(MACHINE-PARSED LINE)#*#...)
9898

9999
$(if $(or $(BUILD_DEPENDENT_IMAGES:no=), $(filter $@,$(MAKECMDGOALS))),
100-
$(call build_image,$(1),$(2),$(3))
100+
$(call build_image,$(1),$(RELEASE)/$(2),$(3))
101101
102102
$(if $(PUSH_IMAGES:no=),
103103
$(call push_image,$(1))
@@ -311,7 +311,7 @@ undeploy-c9s-%: bin/kubectl
311311
.PHONY: test
312312
test-%: bin/kubectl
313313
$(info # Running tests for $* notebook...)
314-
@./scripts/test_jupyter_with_papermill.sh $*
314+
@./scripts/test_jupyter_with_papermill.sh $(RELEASE) $*
315315

316316
# Validate that runtime image meets minimum criteria
317317
# This validation is created from subset of https://github.com/elyra-ai/elyra/blob/9c417d2adc9d9f972de5f98fd37f6945e0357ab9/Makefile#L325

ci/cached-builds/gen_gha_matrix_jobs.py

100644100755
+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#!/usr/bin/env python3
2+
13
import argparse
24
import itertools
35
import json

scripts/test_jupyter_with_papermill.sh

+7-5
Original file line numberDiff line numberDiff line change
@@ -99,18 +99,20 @@ function _get_accelerator_flavor()
9999
# Returns the absolute path of notebook resources in the notebooks/ repo based on the notebook name
100100
#
101101
# Arguments:
102-
# $1 : Name of the notebook identifier
103-
# $2 : [optional] Subdirectory to append to computed absolute path
102+
# $1 : Release to test (2024a, 2024n, ...)
103+
# $2 : Name of the notebook identifier
104+
# $3 : [optional] Subdirectory to append to computed absolute path
104105
# - path should NOT start with a leading /
105106
#
106107
# Returns:
107108
# Absolute path to the jupyter notebook directory for the given notebook test target
108109
function _get_jupyter_notebook_directory()
109110
{
110-
local notebook_id="${1:-}"
111-
local subpath="${2:-}"
111+
local release="${1:-}"
112+
local notebook_id="${2:-}"
113+
local subpath="${3:-}"
112114

113-
local jupyter_base="${root_repo_directory}/jupyter"
115+
local jupyter_base="${root_repo_directory}/${release}/jupyter"
114116
local directory="${jupyter_base}/${notebook_id}/${os_flavor}-${python_flavor}${subpath:+"/$subpath"}"
115117

116118
printf '%s' "${directory}"

0 commit comments

Comments
 (0)