Skip to content

Commit 4a3f08d

Browse files
authored
Fix Check for updates menu item title capitalisation (lensapp#7396)
* Check for updates -> Check for Updates Signed-off-by: Alex Andreev <[email protected]> * Revert debugging changes Signed-off-by: Alex Andreev <[email protected]> * Adding ellipsis to every Check for Updates items Signed-off-by: Alex Andreev <[email protected]> --------- Signed-off-by: Alex Andreev <[email protected]>
1 parent 4b1d740 commit 4a3f08d

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const checkForUpdatesMenuItemInjectable = getInjectable({
2828
id: "check-for-updates",
2929
parentId: isMac ? "mac" : "help",
3030
orderNumber: isMac ? 20 : 50,
31-
label: "Check for updates",
31+
label: "Check for Updates...",
3232
isShown: updatingIsEnabled,
3333

3434
onClick: () => {

packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ describe("installing update using tray", () => {
146146
it("name of tray item for checking updates indicates that checking is happening", () => {
147147
expect(
148148
builder.tray.get("check-for-updates")?.label,
149-
).toBe("Checking for updates...");
149+
).toBe("Checking for Updates...");
150150
});
151151

152152
it("user cannot install update yet", () => {
@@ -177,7 +177,7 @@ describe("installing update using tray", () => {
177177
it("name of tray item for checking updates no longer indicates that checking is happening", () => {
178178
expect(
179179
builder.tray.get("check-for-updates")?.label,
180-
).toBe("Check for updates");
180+
).toBe("Check for Updates...");
181181
});
182182

183183
it("renders", () => {
@@ -241,7 +241,7 @@ describe("installing update using tray", () => {
241241
it("name of tray item for checking updates no longer indicates that downloading is happening", () => {
242242
expect(
243243
builder.tray.get("check-for-updates")?.label,
244-
).toBe("Check for updates");
244+
).toBe("Check for Updates...");
245245
});
246246

247247
it("renders", () => {
@@ -269,7 +269,7 @@ describe("installing update using tray", () => {
269269
it("name of tray item for checking updates no longer indicates that downloading is happening", () => {
270270
expect(
271271
builder.tray.get("check-for-updates")?.label,
272-
).toBe("Check for updates");
272+
).toBe("Check for Updates...");
273273
});
274274

275275
it("renders", () => {

packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ const checkForUpdatesTrayItemInjectable = getInjectable({
4747
}
4848

4949
if (checkingForUpdatesState.value.get()) {
50-
return "Checking for updates...";
50+
return "Checking for Updates...";
5151
}
5252

53-
return "Check for updates";
53+
return "Check for Updates...";
5454
}),
5555

5656
enabled: computed(() => !checkingForUpdatesState.value.get() && !downloadingUpdateState.value.get()),

0 commit comments

Comments
 (0)